Create Window Specific Orientation Extensions #7338
Conversation
| @@ -110,5 +111,19 @@ static void OnBackButtonPressed(Window window) | |||
| s_windowCloseRequestHandler[window].Invoke(); | |||
| } | |||
|
|
|||
| internal static Devices.DisplayOrientation GetOrientation(this IWindow window) | |||
PureWeen
force-pushed
the
fix_winui_flyoutpage_tests
branch
from
e5ef146
to
dc2c2ec
Compare
|
essentials should not have hooks for ui things. There is the DeviceDisplay.SetCurrent(xxx) and that should probably be used. No use having an extension method on IWindow that does nothing window related Also, not sure we have agreed on the definition of orientation... essentials works with display - such as the screen dimensions... This appears to be something that you are doing based on window size? Are they the same? For example, I have a landscape monitor, but my windows app is very tall (think flappy bird) so is that landscape or portrait? And for android, you are reading the activity but essentials looks at the screen. what should we be doing and lets make sure we figure it. |
|
@mattleibow those are all very valid questions :-)
These terms also become very muddy with foldables |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@rookiejava I had just copied the implementation from here Should that code also get updated? Or is that code a little different because you don't have a window to work with? |
Co-authored-by: Kangho Hur <kangho.hur@samsung.com>
Co-authored-by: Kangho Hur <kangho.hur@samsung.com>
PureWeen
force-pushed
the
fix_winui_flyoutpage_tests
branch
from
b72f87c
to
f470609
Compare
Description of Change
Create extensions inside core from the essentials code that's able to base orientation on a passed in window. The FlyoutPage uses orientation information to determine initial layout. We are moving the WinUI tests to run in separate windows so the FlyoutPage needs to be able to base that information off the window it's attached to.
I thought about moving all the essentials bits to extension methods inside essentials and then calling into that but it felt like that would just start mudding up the essentials code. At some point I assume essentials will have better multi window hooks
Issues Fixed
Fixes #7306