[main] Update dependencies from dotnet/aspnetcore #6081

dotnet-maestro · 2022-04-13T19:54:24Z

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

Subscription: f048ef0c-9fda-42a1-fd39-08da1d875c10
Build: 20220512.8
Date Produced: May 12, 2022 11:58:54 PM UTC
Commit: fac970ded3047f63328ff56f59a874bcabf18126
Branch: refs/heads/release/6.0

Updates:
- Microsoft.AspNetCore.Metadata: from 6.0.5 to 6.0.6
- Microsoft.AspNetCore.Components.WebView: from 6.0.5 to 6.0.6
- Microsoft.AspNetCore.Components.Web: from 6.0.5 to 6.0.6
- Microsoft.AspNetCore.Components.Forms: from 6.0.5 to 6.0.6
- Microsoft.AspNetCore.Components.Analyzers: from 6.0.5 to 6.0.6
- Microsoft.AspNetCore.Authorization: from 6.0.5 to 6.0.6
- Microsoft.AspNetCore.Components: from 6.0.5 to 6.0.6
- Microsoft.JSInterop: from 6.0.5 to 6.0.6

…0220413.4 Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Authorization , Microsoft.JSInterop From Version 6.0.4 -> To Version 6.0.5

eng/Version.Details.xml

wtgodbe · 2022-04-13T20:02:16Z

Is there a fabric bot config for this repo? You could get it to auto-approve these PRs

TanayParikh · 2022-04-13T20:05:12Z

Is there a fabric bot config for this repo? You could get it to auto-approve these PRs

Looking through some recent dep-update PRs, that doesn't seem to be something this repo uses (I just see manual approvals).

TanayParikh

Blocking merge as we don't want to upgrade to 6.0.5 yet.

TanayParikh · 2022-04-13T20:20:31Z

@wtgodbe is there a way to only consume publicly available releases (ie. 6.0.4 for now)? Perhaps via a different channel?

wtgodbe · 2022-04-13T20:22:27Z

@wtgodbe is there a way to only consume publicly available releases (ie. 6.0.4 for now)? Perhaps via a different channel?

As far as I know, not automatically. You'd have to disable the subscription, then manually trigger it locally against the specific build that produced 6.0.4 (unless there's some new mechanism for this - @mmitche?)

mmitche · 2022-04-13T20:35:25Z

@wtgodbe is there a way to only consume publicly available releases (ie. 6.0.4 for now)? Perhaps via a different channel?

As far as I know, not automatically. You'd have to disable the subscription, then manually trigger it locally against the specific build that produced 6.0.4 (unless there's some new mechanism for this - @mmitche?)

There's not a mechanism or mechanism planned for this. You can do the update manually though. You find the manifest file for the release, then checkout your main branch and do:

$builds = Get-Content '<manifest file>' | ConvertFrom-Json; $builds.builds | % { if ($_.channels.name -eq ".NET 6 Internal") { darc update-dependencies --id $_.barBuildId } }

This will update against the all runtime repos, though not SDK (you can use another invocation for that), for the given release. The manifest file can be found on vsufile. If you need info on where to look, ping me offline.

…0220413.12 Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Authorization , Microsoft.JSInterop From Version 6.0.4 -> To Version 6.0.5

dougbu · 2022-04-28T18:58:31Z

@mmitche any idea what MAUI-public is or why there's no Details for it❔ Mainly wondering if this PR should be merged by someone who has the right rights…

jonathanpeppers · 2022-04-28T19:03:07Z

eng/Version.Details.xml

-    <Dependency Name="Microsoft.AspNetCore.Authorization" Version="6.0.4">
-      <Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore</Uri>
-      <Sha>f9ae0f5d30be2de3c0de61b5673bd8873231d70a</Sha>
+    <Dependency Name="Microsoft.AspNetCore.Authorization" Version="6.0.5">


Are these packs going to ship the same timeframe as the 6.0.5 dotnet/runtime?

Just checking that these will be on NuGet.org when MAUI ships. /cc @Redth as a reviewer

Are these packs going to ship the same timeframe as the 6.0.5 dotnet/runtime?

It was going to be in a very tight timeframe. I think the decision we'd reached was we want to hold off on merging this PR (and thereby upgrading from 6.0.4 -> 6.0.5) till after GA to be safe.

Mainly wondering if this PR should be merged by someone who has the right rights…
@dougbu

No it should NOT be merged. Ideally we'd only consume this package update once the packages are publicly available, but unfortunately, that doesn't seem to be possible. So blocking the PR was the alternative.

@TanayParikh the workflow above will get you what you want, once the build is officially released (week from Tuesday).

Any change here? i.e. is this PR able to be merged?

mmitche · 2022-04-28T19:08:51Z

@dougbu I don't. It doesn't show up as run on any other PRs I checked.

javiercn · 2022-05-03T13:38:33Z

@mkArtakMSFT do you know if this is still blocked for merging?

TanayParikh · 2022-05-03T15:06:33Z

@mkArtakMSFT do you know if this is still blocked for merging?

It's still blocked. Please see: #6081 (comment)

…0220503.6 Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Authorization , Microsoft.JSInterop From Version 6.0.4 -> To Version 6.0.6

…0220504.26 Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Authorization , Microsoft.JSInterop From Version 6.0.4 -> To Version 6.0.6

…0220505.18 Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Authorization , Microsoft.JSInterop From Version 6.0.4 -> To Version 6.0.6

…0220509.8 Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Authorization , Microsoft.JSInterop From Version 6.0.4 -> To Version 6.0.6

…0220510.8 Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.JSInterop From Version 6.0.4 -> To Version 6.0.6

rmarinho · 2022-05-12T13:19:30Z

Should this be merged now ?

rmarinho · 2022-05-12T13:19:51Z

/azp run

azure-pipelines · 2022-05-12T13:20:10Z

Azure Pipelines successfully started running 2 pipeline(s).

javiercn · 2022-05-12T13:25:33Z

@rmarinho I think so. 6.0.5 is out, which is what we were waiting for, I believe.

Redth · 2022-05-12T13:31:43Z

this is 6.0.6 though? let's pause on merging please.

rmarinho · 2022-05-12T13:35:16Z

Oh right i was thinking it was 6.0.5 also. but i see now is 6.0.6

mmitche · 2022-05-12T15:41:12Z

FYI that 6.0.6 won't ever be the actual 6.0.6 until after release, since 6.0.6 (and 6.0.5 for that matter) are internal only.

rmarinho · 2022-05-12T15:45:03Z

@mmitche 6.0.5 are public no?
https://www.nuget.org/packages/Microsoft.AspNetCore.Components.Forms/6.0.5

mmitche · 2022-05-12T16:02:36Z

@mmitche 6.0.5 are public no? https://www.nuget.org/packages/Microsoft.AspNetCore.Components.Forms/6.0.5

6.0.5 is public, 6.0.6 is still being built.

TanayParikh · 2022-05-12T18:41:30Z

Even if we revert this PR to the 6.0.5 bump, I'm hesitant to take this for GA at this stage. I think it may be better we stick to 6.0.4 for now and upgrade to 6.0.5/6 after GA, I don't want to touch anything at this stage of the release.

rmarinho · 2022-05-12T18:43:52Z

We have this other #7107 with 6.0.5 that will not be for GA but for servicing. We already branched the GA version

TanayParikh · 2022-05-12T18:55:46Z

Created #7109 to merge in 6.0.5 to main. Can't merge this PR as it's 6.0.6

…0220512.8 Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.JSInterop From Version 6.0.5 -> To Version 6.0.6

TanayParikh · 2022-06-15T22:31:40Z

We no longer need this as the dependabot is taking care of this for us #8057. The subscription has also been disabled.

ghost added the area/infrastructure 🏗️ CI, Maestro / Coherency label Apr 13, 2022

TanayParikh reviewed Apr 13, 2022

View reviewed changes

eng/Version.Details.xml Show resolved Hide resolved

TanayParikh requested review from jonathanpeppers and a team April 13, 2022 19:56

wtgodbe approved these changes Apr 13, 2022

View reviewed changes

TanayParikh approved these changes Apr 13, 2022

View reviewed changes

TanayParikh added the do-not-merge Don't merge this PR label Apr 13, 2022

TanayParikh suggested changes Apr 13, 2022

View reviewed changes

dotnet-maestro bot added 2 commits April 14, 2022 13:06

jonathanpeppers reviewed Apr 28, 2022

View reviewed changes

jonathanpeppers requested a review from Redth April 28, 2022 19:03

TanayParikh added the blocked Work that is currently blocked label Apr 28, 2022

dotnet-maestro bot added 6 commits May 4, 2022 12:47

rmarinho added do-not-merge Don't merge this PR and removed do-not-merge Don't merge this PR blocked Work that is currently blocked labels May 12, 2022

TanayParikh added the blocked Work that is currently blocked label May 12, 2022

This was referenced May 12, 2022

Update ASPNETCORE Dependencies to 6.0.5 #7108

Closed

Update ASPNETCORE Dependencies to 6.0.5 #7109

Merged

TanayParikh closed this Jun 15, 2022

TanayParikh deleted the darc-main-cae2c232-320e-44a9-887a-919d6df01459 branch June 15, 2022 22:31

github-actions bot locked and limited conversation to collaborators Dec 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/aspnetcore #6081

[main] Update dependencies from dotnet/aspnetcore #6081

dotnet-maestro bot commented Apr 13, 2022 •

edited

wtgodbe commented Apr 13, 2022

TanayParikh commented Apr 13, 2022

TanayParikh left a comment

TanayParikh commented Apr 13, 2022 •

edited

wtgodbe commented Apr 13, 2022 •

edited by TanayParikh

mmitche commented Apr 13, 2022

dougbu commented Apr 28, 2022

jonathanpeppers Apr 28, 2022

TanayParikh Apr 28, 2022

mmitche Apr 29, 2022

JamesNK May 11, 2022

mmitche commented Apr 28, 2022

javiercn commented May 3, 2022

TanayParikh commented May 3, 2022

rmarinho commented May 12, 2022

rmarinho commented May 12, 2022

azure-pipelines bot commented May 12, 2022

javiercn commented May 12, 2022

Redth commented May 12, 2022

rmarinho commented May 12, 2022

mmitche commented May 12, 2022

rmarinho commented May 12, 2022

mmitche commented May 12, 2022

TanayParikh commented May 12, 2022

rmarinho commented May 12, 2022

TanayParikh commented May 12, 2022

TanayParikh commented Jun 15, 2022 •

edited

[main] Update dependencies from dotnet/aspnetcore #6081

[main] Update dependencies from dotnet/aspnetcore #6081

Conversation

dotnet-maestro bot commented Apr 13, 2022 • edited

From https://github.com/dotnet/aspnetcore

wtgodbe commented Apr 13, 2022

TanayParikh commented Apr 13, 2022

TanayParikh left a comment

Choose a reason for hiding this comment

TanayParikh commented Apr 13, 2022 • edited

wtgodbe commented Apr 13, 2022 • edited by TanayParikh

mmitche commented Apr 13, 2022

dougbu commented Apr 28, 2022

jonathanpeppers Apr 28, 2022

Choose a reason for hiding this comment

TanayParikh Apr 28, 2022

Choose a reason for hiding this comment

mmitche Apr 29, 2022

Choose a reason for hiding this comment

JamesNK May 11, 2022

Choose a reason for hiding this comment

mmitche commented Apr 28, 2022

javiercn commented May 3, 2022

TanayParikh commented May 3, 2022

rmarinho commented May 12, 2022

rmarinho commented May 12, 2022

azure-pipelines bot commented May 12, 2022

javiercn commented May 12, 2022

Redth commented May 12, 2022

rmarinho commented May 12, 2022

mmitche commented May 12, 2022

rmarinho commented May 12, 2022

mmitche commented May 12, 2022

TanayParikh commented May 12, 2022

rmarinho commented May 12, 2022

TanayParikh commented May 12, 2022

TanayParikh commented Jun 15, 2022 • edited

dotnet-maestro bot commented Apr 13, 2022 •

edited

TanayParikh commented Apr 13, 2022 •

edited

wtgodbe commented Apr 13, 2022 •

edited by TanayParikh

TanayParikh commented Jun 15, 2022 •

edited