[Docs] Added pending inline comments to Page class #20933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknaudt21
requested changes
Mar 1, 2024
src/Controls/src/Core/PlatformConfiguration/WindowsSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
jknaudt21
requested changes
Mar 11, 2024
src/Controls/src/Core/PlatformConfiguration/WindowsSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/WindowsSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
| public static void SetPrefersHomeIndicatorAutoHidden(BindableObject element, bool value) | ||
| { | ||
| element.SetValue(PrefersHomeIndicatorAutoHiddenProperty, value); | ||
| } | ||
|
|
||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.iOSSpecific/Page.xml" path="//Member[@MemberName='PrefersHomeIndicatorAutoHidden']/Docs/*" /> | ||
| /// <summary> | ||
| /// Gets a Boolean that indicates whether is allowed to hide the visual indicator for returning to the Home Screen. |
There was a problem hiding this comment.
Similar comment as SetPrefersHomeIndicatorAutoHidden
| public static bool PrefersHomeIndicatorAutoHidden(this IPlatformElementConfiguration<iOS, FormsElement> config) | ||
| { | ||
| return GetPrefersHomeIndicatorAutoHidden(config.Element); | ||
| } | ||
|
|
||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.iOSSpecific/Page.xml" path="//Member[@MemberName='SetPrefersHomeIndicatorAutoHidden'][2]/Docs/*" /> | ||
| /// <summary> | ||
| /// Sets a Boolean that indicates whether is allowed to hide the visual indicator for returning to the Home Screen. |
There was a problem hiding this comment.
How is this property different to SetPrefersHomeIndicatorAutoHidden?
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
jknaudt21
reviewed
Mar 25, 2024
There was a problem hiding this comment.
This file should be entirely deleted
There was a problem hiding this comment.
This file should be entirely deleted
src/Controls/src/Core/PlatformConfiguration/WindowsSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
jsuarezruiz
force-pushed
the
page-comments
branch
from
8136301
to
2159676
Compare
jknaudt21
reviewed
May 7, 2024
jknaudt21
previously approved these changes
May 7, 2024
jknaudt21
approved these changes
May 8, 2024
PureWeen
requested changes
May 8, 2024
| @@ -9,35 +9,56 @@ namespace Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific | |||
| { | |||
| using FormsElement = Maui.Controls.Page; | |||
|
|
|||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific/Page.xml" path="Type[@FullName='Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific.Page']/Docs/*" /> | |||
| /// <summary> | |||
| /// The page instance that Microsoft.Maui.Controls created on the Windows platform. | |||
There was a problem hiding this comment.
This isn't really correct
This is just an extension class for setting platform specifics
| public static ToolbarPlacement GetToolbarPlacement(BindableObject element) | ||
| { | ||
| return (ToolbarPlacement)element.GetValue(ToolbarPlacementProperty); | ||
| } | ||
|
|
||
| /// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific/Page.xml" path="//Member[@MemberName='SetToolbarPlacement'][1]/Docs/*" /> | ||
| /// <summary> | ||
| /// Sets a value that controls the placement of the toolbar. |
There was a problem hiding this comment.
This doesn't actually do anything right now. Is that useful to note ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added pending inline comments to Page class.