Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic docs for ScrollView implementations #19766

Merged
merged 4 commits into from Jan 16, 2024
Merged

Add basic docs for ScrollView implementations #19766

merged 4 commits into from Jan 16, 2024

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Jan 8, 2024

Description of Change

Documents design/implementation details for ScrollView

@hartez hartez marked this pull request as ready for review January 8, 2024 21:17
@hartez hartez requested a review from a team as a code owner January 8, 2024 21:17
rmarinho
rmarinho requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think is working now..

Run cspell --config ./cSpell.json "docs/**/*.md" --no-progress
./docs/design/scrollview.md:66:25 - Unknown word (implemenation)
CSpell: Files checked: 13, Issues found: 1 in 1 files
Error: Process completed with exit code 1.

@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Jan 10, 2024
@rmarinho rmarinho added the area-docs Conceptual docs, API docs, Samples label Jan 11, 2024
@rmarinho rmarinho self-requested a review January 16, 2024 14:41
@rmarinho rmarinho merged commit 3890e04 into main Jan 16, 2024
46 of 48 checks passed
@rmarinho rmarinho deleted the scrollviewhandler-docs branch January 16, 2024 14:42
@eder-em
Copy link

eder-em commented Jan 17, 2024

Love document improvements
LeonardoDicaprioClappingGIF

@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
@Eilon Eilon added area-controls-scrollview ScrollView and removed area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-scrollview ScrollView area-docs Conceptual docs, API docs, Samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hartez @eder-em @rmarinho @Eilon