[CI] Remove template explosion on the maui templates build tests. #15365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-infrastructure
|
/rebase |
github-actions
bot
force-pushed
the
dev/mandel/matrix-build-maui-templates
branch
from
2347f3c
to
9265ef3
Compare
|
/rebase |
github-actions
bot
force-pushed
the
dev/mandel/matrix-build-maui-templates
branch
from
9265ef3
to
dddd12b
Compare
|
/rebase |
github-actions
bot
force-pushed
the
dev/mandel/matrix-build-maui-templates
branch
from
cd2e7e1
to
4cc518e
Compare
pjcollins
reviewed
Jun 20, 2023
| if ($env:AGENT_JOBSTATUS -eq "SucceededWithIssues") { | ||
| Write-Host "##vso[task.complete result=Failed;]DONE" | ||
| } | ||
| displayName: Fail if any issues occurred | ||
|
|
||
| - ${{ each RunPlatform in parameters.RunPlatforms }}: |
There was a problem hiding this comment.
Should we do the same for the run templates jobs? I think we'd want to use the matrix strategy here as well if it produces less YAML, but that could be done in a future PR.
There was a problem hiding this comment.
You are 100% correct, I was going to dos it in a future PR :)
Move to minimize the size of the yaml by using a matrix over expanding the same templates twice. This will reduce the final size of the yaml of the pipeline.
mandel-macaque
force-pushed
the
dev/mandel/matrix-build-maui-templates
branch
from
4cc518e
to
52b612d
Compare
pjcollins
approved these changes
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to minimize the size of the yaml by using a matrix over expanding the same templates twice. This will reduce the final size of the yaml of the pipeline.