Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Avoid OnDestroy lifecycle event firing twice #14799

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[Android] Avoid OnDestroy lifecycle event firing twice #14799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/Core/src/Platform/Android/MauiAppCompatActivity.Lifecycle.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,5 @@ protected override void OnRestoreInstanceState(Bundle savedInstanceState)

MauiApplication.Current?.Services?.InvokeLifecycleEvents<AndroidLifecycle.OnRestoreInstanceState>(del => del(this, savedInstanceState));
}

protected override void OnDestroy()
{
base.OnDestroy();

MauiApplication.Current?.Services?.InvokeLifecycleEvents<AndroidLifecycle.OnDestroy>(del => del(this));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already firing here

maui/src/Core/src/Platform/Android/MauiApplication.cs

Lines 93 to 94 in 8c68558

public void OnActivityDestroyed(Activity activity) =>
Current.Services?.InvokeLifecycleEvents<AndroidLifecycle.OnDestroy>(del => del(activity));

}
}
}
1 change: 0 additions & 1 deletion src/Core/src/PublicAPI/net-android/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2218,7 +2218,6 @@ override Microsoft.Maui.MauiAppCompatActivity.OnActivityResult(int requestCode,
override Microsoft.Maui.MauiAppCompatActivity.OnBackPressed() -> void
override Microsoft.Maui.MauiAppCompatActivity.OnConfigurationChanged(Android.Content.Res.Configuration! newConfig) -> void
override Microsoft.Maui.MauiAppCompatActivity.OnCreate(Android.OS.Bundle? savedInstanceState) -> void
override Microsoft.Maui.MauiAppCompatActivity.OnDestroy() -> void
override Microsoft.Maui.MauiAppCompatActivity.OnNewIntent(Android.Content.Intent? intent) -> void
override Microsoft.Maui.MauiAppCompatActivity.OnPostCreate(Android.OS.Bundle? savedInstanceState) -> void
override Microsoft.Maui.MauiAppCompatActivity.OnPostResume() -> void
Expand Down