Add ICanSummarize and implement IEstimator.Summary for StandardTrainers #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
LittleLittleCloud
changed the title
LittleLittleCloud
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| @@ -42,7 +42,6 @@ | |||
| <ProjectReference Include="..\Microsoft.ML.OnnxTransformer\Microsoft.ML.OnnxTransformer.csproj" /> | |||
| <ProjectReference Include="..\Microsoft.ML.SearchSpace\Microsoft.ML.SearchSpace.csproj"> | |||
| <PrivateAssets>all</PrivateAssets> | |||
| <IncludeInNuget>true</IncludeInNuget> | |||
There was a problem hiding this comment.
Does removing this line break anything?
| @@ -3,8 +3,10 @@ | |||
| // See the LICENSE file in the project root for more information. | |||
|
|
|||
| using System.Runtime.CompilerServices; | |||
| using Microsoft.ML; | |||
There was a problem hiding this comment.
Is this using statement needed here? Doesn't seem like it.
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <IncludeInPackage>Microsoft.ML.Core</IncludeInPackage> | |||
There was a problem hiding this comment.
What package is this going to be included in now?
|
|
||
| namespace Microsoft.ML.SearchSpace | ||
| { | ||
| internal class Schema |
There was a problem hiding this comment.
Could we change the name of this class from Schema to something else? We already use schema for many things, and this seems more like a summary rather than a schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.#6563
This PR adds a
Summaryfunction to allIEstimator<ITransformer>which prints meta data like estimator name, hyper-parameters and other informations. This helps code generator in model builder to generate pipeline code.