Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #6038

Merged
merged 1 commit into from Jan 11, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20220106.6
  • Date Produced: January 6, 2022 9:12:49 PM UTC
  • Commit: 34bc5b1611e13bd0ee6a9f38ab8524d2ee489be5
  • Branch: refs/heads/main

…106.6

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21253.2 -> To Version 7.0.0-beta.22056.6
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #6038 (145605a) into main (52ddbcd) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6038      +/-   ##
==========================================
+ Coverage   68.54%   68.60%   +0.05%     
==========================================
  Files        1146     1146              
  Lines      245450   245450              
  Branches    25637    25637              
==========================================
+ Hits       168249   168383     +134     
+ Misses      70494    70377     -117     
+ Partials     6707     6690      -17     
Flag Coverage Δ
Debug 68.60% <ø> (+0.05%) ⬆️
production 63.40% <ø> (+0.06%) ⬆️
test 88.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...StandardTrainers/Standard/LinearModelParameters.cs 66.07% <0.00%> (+0.25%) ⬆️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 67.35% <0.00%> (+0.51%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 92.15% <0.00%> (+1.02%) ⬆️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 72.78% <0.00%> (+1.36%) ⬆️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 88.13% <0.00%> (+3.07%) ⬆️
...est/Microsoft.ML.Core.Tests/UnitTests/TestHosts.cs 100.00% <0.00%> (+3.44%) ⬆️
src/Microsoft.ML.Data/Training/TrainerUtils.cs 69.67% <0.00%> (+3.81%) ⬆️
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs 90.76% <0.00%> (+7.15%) ⬆️

@ericstj
Copy link
Member

ericstj commented Jan 10, 2022

CI failure is https://dev.azure.com/dnceng/public/_build/results?buildId=1545341&view=ms.vss-test-web.build-test-results-tab&runId=43673634&resultId=101358&paneView=debug

Starting test: Microsoft.ML.Tests.ImageTests.TestSaveImages
    Microsoft.ML.Tests.ImageTests.TestBackAndForthConversionWithAlphaInterleave [FAIL]
�[31;1m�[m�[37m      System.ArgumentException : Parameter is not valid.
�[m�[30;1m      Stack Trace:
�[m�[37m           at System.Drawing.Bitmap.UnlockBits(BitmapData bitmapdata)
�[m�[37m        /__w/1/s/src/Microsoft.ML.ImageAnalytics/VectorToImageTransform.cs(431,0): at Microsoft.ML.Transforms.Image.VectorToImageConvertingTransformer.Mapper.<>c__DisplayClass5_0`1.<GetterFromType>b__0(Bitmap& dst)
�[m�[37m        /__w/1/s/test/Microsoft.ML.Tests/ImagesTests.cs(343,0): at Microsoft.ML.Tests.ImageTests.TestBackAndForthConversionWithAlphaInterleave()

Which was previously seen here:
#5838 (comment)

I'm going to rerun to see if it's flaky. If so I'll file an issue.

@michaelgsharp
Copy link
Member

@ericstj its a flaky test dealing with System.Drawing on the arm systems. When we switch off of System.Drawing this will go away, but it may be good to temp disable it for now since it seems to happen on a decent amount of PR's.

@michaelgsharp michaelgsharp merged commit 0b2bd3a into main Jan 11, 2022
@michaelgsharp michaelgsharp deleted the darc-main-fffc66a3-8a3b-4a6a-aa62-da497e6f9d43 branch January 11, 2022 02:13
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants