Changes from PR comments.

dotnet · Sep 24, 2021 · 88e13d0 · 88e13d0
1 parent 86b7b95
commit 88e13d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs b/src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs
@@ -200,9 +200,11 @@ private protected CalibratorTransformer(IHostEnvironment env, ModelLoadContext c
             }
         }
 
-        public string FeatureColumnName => DefaultColumnNames.Score;
+        string ISingleFeaturePredictionTransformer<TICalibrator>.FeatureColumnName => DefaultColumnNames.Score;
+        string ISingleFeaturePredictionTransformer.FeatureColumnName => ((ISingleFeaturePredictionTransformer<TICalibrator>)this).FeatureColumnName;
 
-        public DataViewType FeatureColumnType => NumberDataViewType.Single;
+        DataViewType ISingleFeaturePredictionTransformer<TICalibrator>.FeatureColumnType => NumberDataViewType.Single;
+        DataViewType ISingleFeaturePredictionTransformer.FeatureColumnType => ((ISingleFeaturePredictionTransformer<TICalibrator>)this).FeatureColumnType;
 
         TICalibrator IPredictionTransformer<TICalibrator>.Model => _calibrator;
 

diff --git a/src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs b/src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs
@@ -669,9 +669,9 @@ private static double[] ComputeSequenceDeltas(IReadOnlyList<double> a, IReadOnly
             {
                 foreach (var transformer in chain.Reverse())
                 {
-                    if (transformer is ISingleFeaturePredictionTransformer)
+                    if (transformer is ISingleFeaturePredictionTransformer singlePredictionTransformer)
                     {
-                        lastTransformer = transformer as ISingleFeaturePredictionTransformer;
+                        lastTransformer = singlePredictionTransformer;
                         break;
                     }
                 }
@@ -692,7 +692,7 @@ private static double[] ComputeSequenceDeltas(IReadOnlyList<double> a, IReadOnly
                 resultInitializer,
                 evaluationFunc,
                 deltaFunc,
-                lastTransformer.FeatureColumnName,
+                featureColumnName,
                 permutationCount,
                 useFeatureWeightFilter,
                 numberOfExamplesToUse