Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fedora-36, debian-stretch and ubuntu-18.04 image tags #17919

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

v-wuzhai
Copy link
Member

@v-wuzhai v-wuzhai commented Dec 6, 2023

  • Please add description for changes you are making.
  • If there is an issue related to this PR, please add the reference.

@v-wuzhai v-wuzhai reopened this Dec 7, 2023
@v-wuzhai v-wuzhai force-pushed the dev/v-wuzhai/Update-to-latest-OSes branch from cf9e176 to dbea75d Compare December 7, 2023 06:42
@v-wuzhai v-wuzhai changed the title Update image tags Update fedora-36, debian-stretch and ubuntu-18.04 image tags Dec 7, 2023
@v-wuzhai
Copy link
Member Author

v-wuzhai commented Dec 7, 2023

@ellahathaway @marcpopMSFT Looks like we miss the ICU package or we can disable the use of ICU.

Couldn't find a valid ICU package installed on the system. Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support.

@marcpopMSFT
Copy link
Member

@dotnet/dnceng may have instructions on how to update the base container image for fedora to include icu.

@ellahathaway
Copy link
Member

The Dockerfiles for fedora-39 were added as part of dotnet/dotnet-buildtools-prereqs-docker#934. May have to add something like https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/c1b3538eb5349768281a257de4a473b1bd0999a8/src/alpine/3.18/helix/amd64/Dockerfile#L7

@lbussell Do you know if this is the correct approach?

@v-wuzhai
Copy link
Member Author

v-wuzhai commented Dec 12, 2023

@ellahathaway @lbussell @marcpopMSFT I've added some code to install icu in Fedora39, could you please help review it?

@lbussell
Copy link

I approved that PR. I am wondering however why Fedora 36 didn't require ICU for this same pipeline.

Let's also link the relevant issue: #17888

@v-wuzhai
Copy link
Member Author

v-wuzhai commented Jan 9, 2024

It seems that installing icu did not solve the problem, but I noticed that Fedora39 did not support 2.1 and 2.2 frameworks in the documentation through reading the materials, so I updated the test framework, can you have a look?

@v-wuzhai v-wuzhai changed the base branch from release/8.0.2xx to release/8.0.3xx January 23, 2024 02:20
@marcpopMSFT marcpopMSFT merged commit a245cf7 into release/8.0.3xx Jan 23, 2024
16 checks passed
@marcpopMSFT marcpopMSFT deleted the dev/v-wuzhai/Update-to-latest-OSes branch January 23, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants