Allow access modifiers to auto properties getters and setters

[Tangent-90]

Description

Continue of #16687,
Fixes #16854

Checklist

• Test cases added
• sig file support
• new syntax in fsi printing
  
• new syntax in quickinfo
  
• new syntax in sig file generation

module Program

type A() =
    member val internal B: int = 0 with get, set
    member val D: int = 0 with internal get, private set
    member internal _.F with get() = 1 and set (v: int) = ()
    member internal _.G with get(x: int) = 1 and set (x: int) (v: int) = ()

// above generates
module Program

type A =
    
    new: unit -> A
    
    member B: int with internal get, internal set
    
    member D: int with internal get, private set
    
    member F: int with internal get, internal set
    
    member G: x: int -> int with internal get, internal set

• Performance benchmarks added in case of performance changes

• Release notes entry updated:

  Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

  Release notes files:

  • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
  • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
  • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

  Information about the release notes entries format can be found in the documentation.
  Example:

  • More inlines for Result module. (PR #16106)
  • Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363)
    *while! (Language suggestion #1038, PR #14238)

  If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/8.0.400.md
LanguageFeatures.fsi	docs/release-notes/.Language/preview.md

[nojaf]

Could you add a test to https://github.com/dotnet/fsharp/blob/711de175bf0c7ddfda4005c3334606b90bb11146/tests/FSharp.Compiler.ComponentTests/Signatures/SigGenerationRoundTripTests.fs, please?

That will ensure the generated signature is valid for the implementation.

[Tangent-90]

protected also displayed in tooltip

[Tangent-90]

Could you add a test to https://github.com/dotnet/fsharp/blob/711de175bf0c7ddfda4005c3334606b90bb11146/tests/FSharp.Compiler.ComponentTests/Signatures/SigGenerationRoundTripTests.fs, please?你能 https://github.com/dotnet/fsharp/blob/711de175bf0c7ddfda4005c3334606b90bb11146/tests/FSharp.Compiler.ComponentTests/Signatures/SigGenerationRoundTripTests.fs 添加一个测试吗？

That will ensure the generated signature is valid for the implementation.这将确保生成的签名对实现有效。

added

[Tangent-90]

I make the new signature generation way under the preview flag. Then some tests with signature hardcoded into error msg are OK with net8.0 (current version) but not OK under preview.

[Tangent-90]

add a new error to disallow access modifiers in an SRTP constraint

and will raise a warning in <= 8.0

[abonie]

@Tangent-90 , will you have time to fix the conflict here? It's pretty simple, but probably best to do it locally and have the .xlf files be generated again (instead of doing it manually)

[Tangent-90]

@Tangent-90 , will you have time to fix the conflict here? It's pretty simple, but probably best to do it locally and have the .xlf files be generated again (instead of doing it manually)

Maybe two days later