Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16708 / Some errors are not reported if any of previous files contain errors #16719

Merged
merged 12 commits into from
Mar 22, 2024

Conversation

0101
Copy link
Contributor

@0101 0101 commented Feb 15, 2024

Description

Fixes #16708

I don't know what originally caused this, but here's a proposed fix. We move the playback of background diagnostics to after we do a type check, so that previous errors don't trigger the suppression check for cascading errors.

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

Copy link
Contributor

github-actions bot commented Feb 15, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@majocha
Copy link
Contributor

majocha commented Feb 21, 2024

I don't know what originally caused this,

If it's fairly recent, also #15840 comes to mind.

@0101 0101 marked this pull request as ready for review February 21, 2024 11:50
@0101 0101 requested a review from a team as a code owner February 21, 2024 11:50
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find the reason why the check originally was where it was? I mean the fix can probably go in since everything is green, but I am still paranoid if this will not break or regress something else.

@0101
Copy link
Contributor Author

0101 commented Feb 21, 2024

I did not. Git blame only lead to refactoring/cleanup commits and I was too lazy to dig deeper or set up a bisect script.

The only side-effect of this change that comes to mind is that the diagnostics will potentially be in different order. But I don't think you can say one ordering is better than the other. File related diagnostics will still be in the same order as before, just whatever else might be at the end now.

And if this breaks something that we don't have tests for then we can fix it and add those tests when it comes up 🤷

@vzarytovskii vzarytovskii enabled auto-merge (squash) March 4, 2024 18:09
@vzarytovskii vzarytovskii merged commit 51013da into dotnet:main Mar 22, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Some errors are not reported if any of previous files contain errors
4 participants