Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tidy: simplify tuple info #16507

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

charlesroddie
Copy link
Contributor

Description

The type TupInfo was uncessary and not documented. It reduces to a bool (representing whether the tuple is a struct), allowing simplification of code. The uses of this bool are now documented as isStruct. A few methods can be simplified or deleted as a result.

NO_RELEASE_NOTES

@charlesroddie charlesroddie requested a review from a team as a code owner January 10, 2024 08:09
Copy link
Contributor

github-actions bot commented Jan 10, 2024

❗ Release notes required

@charlesroddie,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No release notes found or release notes format is not correct

@charlesroddie charlesroddie changed the title Tidy: simplify tuple info [WIP] Tidy: simplify tuple info Jan 10, 2024
@charlesroddie charlesroddie marked this pull request as draft January 10, 2024 08:23
@charlesroddie
Copy link
Contributor Author

charlesroddie commented Jan 20, 2024

I am doing something tiny in this PR to figure out the process again before doing something interesting.

Currently if I run build.cmd on my system on main I get

C:\Users\charl\source\repos\fsharp\buildtools\buildtools.targets(30,5): error MSB3073: The command ""C:\Program Files\d
otnet\dotnet.exe" "C:\Users\charl\source\repos\fsharp\artifacts\\Bootstrap\fslex\fslex.dll" -o "C:\Users\charl\source\r
epos\fsharp\artifacts\obj\FSharp.Compiler.Service\Debug\netstandard2.0\illex.fs" --module FSharp.Compiler.AbstractIL.As
ciiLexer --internal --open Internal.Utilities.Text.Lexing --open FSharp.Compiler.AbstractIL.AsciiParser --unicode --lex
lib Internal.Utilities.Text.Lexing AbstractIL\illex.fsl" exited with code 1. [C:\Users\charl\source\repos\fsharp\src\Co
mpiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]

@vzarytovskii
Copy link
Member

I am doing something tiny in this PR to figure out the process again before doing something interesting.

Currently if I run build.cmd on my system on main I get


C:\Users\charl\source\repos\fsharp\buildtools\buildtools.targets(30,5): error MSB3073: The command ""C:\Program Files\d

otnet\dotnet.exe" "C:\Users\charl\source\repos\fsharp\artifacts\\Bootstrap\fslex\fslex.dll" -o "C:\Users\charl\source\r

epos\fsharp\artifacts\obj\FSharp.Compiler.Service\Debug\netstandard2.0\illex.fs" --module FSharp.Compiler.AbstractIL.As

ciiLexer --internal --open Internal.Utilities.Text.Lexing --open FSharp.Compiler.AbstractIL.AsciiParser --unicode --lex

lib Internal.Utilities.Text.Lexing AbstractIL\illex.fsl" exited with code 1. [C:\Users\charl\source\repos\fsharp\src\Co

mpiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]

Hard to tell what's wrong, please run detailed build or collect the binlog, it should show whole error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

None yet

2 participants