more nowarning in tests

dotnet · Jan 5, 2021 · 96a6a05 · 96a6a05
1 parent ae20dc2
commit 96a6a05
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/tests/FSharp.Compiler.UnitTests/FSharp.Compiler.UnitTests.fsproj b/tests/FSharp.Compiler.UnitTests/FSharp.Compiler.UnitTests.fsproj
@@ -9,7 +9,7 @@
     <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
     <DefineConstants>$(DefineConstants);ASSUME_PREVIEW_FSHARP_CORE</DefineConstants>
     <UnitTestType>xunit</UnitTestType>
-    <NoWarn>$(NoWarn);3186;1104;1182</NoWarn>
+    <NoWarn>$(NoWarn);3186;1104</NoWarn>
   </PropertyGroup>
 
     <ItemGroup>

diff --git a/tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj b/tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj
@@ -6,7 +6,7 @@
     <TargetFrameworks>net472;netcoreapp3.1</TargetFrameworks>
     <TargetFrameworks Condition="'$(OS)' == 'Unix'">netcoreapp3.1</TargetFrameworks>
     <OutputType>Library</OutputType>
-    <NoWarn>1182</NoWarn>
+    <NoWarn>$(NoWarn);1182</NoWarn>
 
     <AssemblyName>FSharp.Core.UnitTests</AssemblyName>
     <PackageId>Microsoft.FSharp.Core.UnitTests</PackageId>

diff --git a/tests/fsharp/FSharpSuite.Tests.fsproj b/tests/fsharp/FSharpSuite.Tests.fsproj
@@ -11,9 +11,8 @@
     <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
     <Optimize>false</Optimize>
     <Tailcalls>false</Tailcalls>
-    <OtherFlags>$(OtherFlags) --warnon:1182</OtherFlags>
     <UnitTestType>nunit</UnitTestType>
-    <NoWarn>3186;1182</NoWarn>
+    <NoWarn>$(NoWarn);3186</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/tests/service/data/TestTP/TestTP.fsproj b/tests/service/data/TestTP/TestTP.fsproj
@@ -5,7 +5,7 @@
     <TargetFramework>net472</TargetFramework>
     <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
     <UnitTestType>nunit</UnitTestType>
-    <OtherFlags>--nowarn:3390 --nowarn:3218</OtherFlags>
+    <NoWarn>$(NoWarn);3390;3218;1182</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/...ders/DummyProviderForLanguageServiceTesting/DummyProviderForLanguageServiceTesting.fsproj b/...ders/DummyProviderForLanguageServiceTesting/DummyProviderForLanguageServiceTesting.fsproj
@@ -5,7 +5,7 @@
   <PropertyGroup>
     <TargetFramework>net472</TargetFramework>
     <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
-    <OtherFlags>--nowarn:3390 --nowarn:3218 --nowarn:1182</OtherFlags>
+    <NoWarn>$(NoWarn);3390;3218;1182</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>