Fix to #33678 - TimeOnly.FromDateTime() could not be translated in EF Core 8 #33689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
fix33678
branch
2 times, most recently
from
9c66372
to
6a78b92
Compare
ErikEJ
reviewed
May 8, 2024
|
@ErikEJ ExpressionExtensions that's used to access InferTypeMapping call is ambiguous otherwise |
… Core 8 Adding translation for TimeOnly.FromDateTime and TimeOnly.FromTimeSpan. We already had support for DateOnly.FromDateTime. Fixes #33678
ajcvickers
reviewed
May 8, 2024
|
|
||
| if ((method == FromDateTime || method == FromTimeSpan) | ||
| && instance is null | ||
| && arguments.Count == 1) |
There was a problem hiding this comment.
Is this sufficiently resilient? What if another overload is added with one parameter? Check for the parameter type as well to be sure?
There was a problem hiding this comment.
GetRuntimeMethod already checks parameter type
ajcvickers
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding translation for TimeOnly.FromDateTime and TimeOnly.FromTimeSpan. We already had support for DateOnly.FromDateTime.
Fixes #33678