Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SqlFragmentExpression to have Type/type mapping #33053

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roji
Copy link
Member

@roji roji commented Feb 10, 2024

Confirmed that this unblocks the scenario in #32969.

Closes #32969

@roji roji requested a review from a team February 10, 2024 15:41
@SamMonoRT
Copy link
Member

are the CI failures related to the changes?

@roji
Copy link
Member Author

roji commented Feb 29, 2024

@SamMonoRT probably yes - I have to find the time to finish this PR...

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning SqlFragmentExpression from HasTranslation doesn't work (switches to client evaluation)
3 participants