Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use provider discriminator values for OfType() #32878

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use provider discriminator values for OfType() #32878

wants to merge 1 commit into from

Conversation

roji
Copy link
Member

@roji roji commented Jan 22, 2024

Fixes #32865

@roji roji requested a review from a team January 22, 2024 10:33
@roji
Copy link
Member Author

roji commented Jan 22, 2024

There are unfortunately various other places where we create constants with the model CLR type for discriminators, and it seems that converting those may not be completely trivial...

@roji roji marked this pull request as draft January 22, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EF8 core: filtering by enum doesn't work with TPH and OfType
2 participants
@roji @ajcvickers