Various stuff from EFCore.PG JSON work #32255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Nov 8, 2023
| @@ -47,6 +47,59 @@ public virtual void Can_read_write_collection_of_ASCII_string_JSON_values(object | |||
| { RelationalAnnotationNames.StoreType, storeType }, { CoreAnnotationNames.Unicode, false } | |||
| }); | |||
|
|
|||
| public override void Can_read_write_ulong_enum_JSON_values(EnumU64 value, string json) | |||
There was a problem hiding this comment.
This lifts the overrides for unsigned types to the relational level, since SQL databases don't have unsigned types.
AndriySvyryd
reviewed
Nov 8, 2023
Comment on lines
+2534
to
+2536
| throw new InvalidOperationException( | ||
| RelationalStrings.JsonValueReadWriterMissingOnTypeMapping( | ||
| property.GetTypeMapping().GetType().Name, property.Name, property.DeclaringType.DisplayName())); |
There was a problem hiding this comment.
This would be better suited for model validation
There was a problem hiding this comment.
Yeah, I agree. Unless you have some specific objections, I'll also leave this here just in case.
There was a problem hiding this comment.
It would be duplicate code, we generally don't throw for things that were already validated to be true. You could leave it as an assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various mostly trivial changes that came out of the EFCore.PG JSON work (npgsql/efcore.pg#2922).