Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme for EF core Nuget Package #30469

Closed
wants to merge 1 commit into from

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Mar 14, 2023

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Add readme file for nuget package: https://www.nuget.org/packages/Microsoft.EntityFrameworkCore/

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

Rendered README: https://github.com/dotnet/efcore/blob/32e73aebc1d64bbd519aaeb788547829ff173ecb/src/EFCore/README.md

Address: #30467, #26556

Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple of minor comments.

@ajcvickers
Copy link
Member

Superseded by #30934. Thanks @lyndaidaii for doing the work here,

@ajcvickers ajcvickers closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants