Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize type checking in model differ #28381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modernize type checking in model differ #28381

wants to merge 1 commit into from

Conversation

roji
Copy link
Member

@roji roji commented Jul 6, 2022

Just some C# modernization since I was in the area...

@roji roji requested a review from bricelam July 6, 2022 18:05
bricelam
bricelam approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... There's a subtle difference in that these checks will now include subtypes. But that's probably fine.

@roji
Copy link
Member Author

roji commented Jul 6, 2022

Yeah, ordering is important in the new code, whereas it wasn't important in the old one, because the matching was against specific types only.

@roji
Copy link
Member Author

roji commented Nov 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@roji
Copy link
Member Author

roji commented Nov 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
propose-close
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roji @bricelam