Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate x.parse #28337

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Translate x.parse #28337

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
93564ff
Added tests against x.Parse(string)
Jun 27, 2022
79b94e8
Added SqlServerParseTranslator
Jun 27, 2022
92401eb
Add failing tests in Sqlite and Cosmos
Jun 28, 2022
c758b48
Order translators alphabetically
Jun 29, 2022
2acf362
Renamed TypeMapping to ClrTypeToStoreTypeMap
Jun 29, 2022
3976d4b
Added more tests.
Jul 7, 2022
3a7e6a5
Write cleaner code.
Jul 11, 2022
3f10651
Remove redundant tests.
Jul 11, 2022
cf0f4ae
Parse and Convert are not implemented in Sqlite, so exceptions thrown…
Apr 25, 2023
d9447cb
The tested invocation should be in the Where clause
Apr 25, 2023
2706a05
Use type inference instead of fixed type
May 4, 2023
bfad808
Merge branch 'main' into translate-x.parse
MaRK0960 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
48 changes: 48 additions & 0 deletions test/EFCore.Cosmos.FunctionalTests/Query/NorthwindFunctionsQueryCosmosTest.cs
View file
Open in desktop
Expand Up @@ -815,6 +815,54 @@ public override async Task Convert_ToString(bool async)
AssertSql();
}

public override async Task Byte_Parse(bool async)
{
// Cosmos client evaluation. Issue #17246.
roji marked this conversation as resolved.
Show resolved Hide resolved
await AssertTranslationFailed(() => base.Byte_Parse(async));

AssertSql();
}

public override async Task Decimal_Parse(bool async)
{
// Cosmos client evaluation. Issue #17246.
await AssertTranslationFailed(() => base.Decimal_Parse(async));

AssertSql();
}

public override async Task Double_Parse(bool async)
{
// Cosmos client evaluation. Issue #17246.
await AssertTranslationFailed(() => base.Double_Parse(async));

AssertSql();
}

public override async Task Short_Parse(bool async)
{
// Cosmos client evaluation. Issue #17246.
await AssertTranslationFailed(() => base.Short_Parse(async));

AssertSql();
}

public override async Task Int_Parse(bool async)
{
// Cosmos client evaluation. Issue #17246.
await AssertTranslationFailed(() => base.Int_Parse(async));

AssertSql();
}

public override async Task Long_Parse(bool async)
{
// Cosmos client evaluation. Issue #17246.
await AssertTranslationFailed(() => base.Long_Parse(async));

AssertSql();
}

public override async Task Indexof_with_emptystring(bool async)
{
await base.Indexof_with_emptystring(async);
Expand Down
18 changes: 18 additions & 0 deletions test/EFCore.Sqlite.FunctionalTests/Query/NorthwindFunctionsQuerySqliteTest.cs
View file
Open in desktop
Expand Up @@ -39,6 +39,24 @@ public override Task Convert_ToInt64(bool async)
public override Task Convert_ToString(bool async)
=> AssertTranslationFailed(() => base.Convert_ToString(async));

public override Task Byte_Parse(bool async)
=> AssertTranslationFailed(() => base.Byte_Parse(async));

public override Task Decimal_Parse(bool async)
=> AssertTranslationFailed(() => base.Decimal_Parse(async));

public override Task Double_Parse(bool async)
=> AssertTranslationFailed(() => base.Double_Parse(async));

public override Task Short_Parse(bool async)
=> AssertTranslationFailed(() => base.Short_Parse(async));

public override Task Int_Parse(bool async)
=> AssertTranslationFailed(() => base.Int_Parse(async));

public override Task Long_Parse(bool async)
=> AssertTranslationFailed(() => base.Long_Parse(async));

public override Task Projecting_Math_Truncate_and_ordering_by_it_twice(bool async)
=> AssertTranslationFailed(() => base.Projecting_Math_Truncate_and_ordering_by_it_twice(async));

Expand Down