[5.0.x] SqlServer: Add Cast to (n)varchar(max) when injecting Concat for multi-line seed data #24944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
May 24, 2021
src/EFCore.SqlServer/Storage/Internal/SqlServerStringTypeMapping.cs
Outdated
Show resolved
Hide resolved
…i-line seed data Resolves #24112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24112
Description
Silent truncation happens when using seed data containing line breaks and longer than 4000 bytes length.
Customer Impact
This causes corruption in user data due to truncation.
How found
Reported by a customer.
Test coverage
Test coverage for this case has been added in this PR.
Regression?
Yes, from EF Core 3.1.
Risk
Low. The change happens in SQL literal generation which is used extensively in various parts to generate SQL and well covered by tests. The fix is also quirked.