[5.0.x] Don't leave unknown FK values when principal is known but has not-set, non-generated, value #24178
+91
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not-set, non-generated, value Port of 6.0 fix #23875 to 5.0 release. Fixes #23730 **Description** An exception is thrown when no key value is set for a non-generated key of an owned type. Normally this is a negative case since non-generated key values must be explicitly set. However, this can works when the non-generated value is part of a composite key for which other parts of the key are generated. In this case, the non-generated part can have the same default value for multiple inserts without violating the primary key constraint. **Customer Impact** This is a regression for the case described above. There is no reasonable workaround. (We already fixed this for EF Core 6.0, but decided not to patch since it seemed to be a regression only in a negative case. Since then other customers have reported the issue and one customer outlined the scenario above where it is a regression in working code.) **How found** Reported by multiple customers. **Test coverage** Test coverage for this case has been added in this PR. **Regression?** Yes, from EF Core 3.1. **Risk** Low. The fix is already in EF Core 6.0 and is targetted to this case. Also quirked.
AndriySvyryd
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of 6.0 fix #23875 to 5.0 release.
Fixes #23730
Description
An exception is thrown when no key value is set for a non-generated key of an owned type. Normally this is a negative case since non-generated key values must be explicitly set. However, this can works when the non-generated value is part of a composite key for which other parts of the key are generated. In this case, the non-generated part can have the same default value for multiple inserts without violating the primary key constraint.
Customer Impact
This is a regression for the case described above. There is no reasonable workaround.
(We already fixed this for EF Core 6.0, but decided not to patch since it seemed to be a regression only in a negative case. Since then other customers have reported the issue and one customer outlined the scenario above where it is a regression in working code.)
How found
Reported by multiple customers.
Test coverage
Test coverage for this case has been added in this PR.
Regression?
Yes, from EF Core 3.1.
Risk
Low. The fix is already in EF Core 6.0 and is targetted to this case. Also quirked.