Skip to content

Commit

Permalink
Show file tree
Hide file tree
Showing 539 changed files with 16,037 additions and 7,610 deletions.
14 changes: 7 additions & 7 deletions Components.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,27 +32,27 @@ To enable full offline source-building of the VMR, we have no other choice than
- `src/format`
*[dotnet/format@06fb492](https://github.com/dotnet/format/tree/06fb492cb53e558598e9bf5ee4dd09acc5888a01)*
- `src/fsharp`
*[dotnet/fsharp@4a39419](https://github.com/dotnet/fsharp/tree/4a394198efadc455334ae272954ece372aea4de2)*
*[dotnet/fsharp@20b263a](https://github.com/dotnet/fsharp/tree/20b263ab495669df94b309fce12584b207dc765c)*
- `src/installer`
*[dotnet/installer@09d6f38](https://github.com/dotnet/installer/tree/09d6f381e6917ee70cf6cbc6109c675c4a51bf77)*
*[dotnet/installer@81f61d8](https://github.com/dotnet/installer/tree/81f61d829031f71887c49938993e8e2c4cc1eb70)*
- `src/msbuild`
*[dotnet/msbuild@89b42a4](https://github.com/dotnet/msbuild/tree/89b42a486cf83aa08780da10c4b41f95db9fd60d)*
*[dotnet/msbuild@7ca3c98](https://github.com/dotnet/msbuild/tree/7ca3c98fad986066bbf2802c863236b4a0f4e34a)*
- `src/nuget-client`
*[nuget/nuget.client@1845d6b](https://github.com/nuget/nuget.client/tree/1845d6bd450a7453d573035371c9fec43683d1ef)*
*[nuget/nuget.client@fb50d1a](https://github.com/nuget/nuget.client/tree/fb50d1a45ed10b39b5f335bc3a4bdcaea9b951cf)*
- `src/nuget-client/submodules/NuGet.Build.Localization`
*[NuGet/NuGet.Build.Localization@f15db7b](https://github.com/NuGet/NuGet.Build.Localization/tree/f15db7b7c6f5affbea268632ef8333d2687c8031)*
- `src/razor`
*[dotnet/razor@0294056](https://github.com/dotnet/razor/tree/0294056d5b40faada727e267ec6e44150d199b71)*
*[dotnet/razor@464030f](https://github.com/dotnet/razor/tree/464030ffb65aba45250a1c200bc3528d5dd7a430)*
- `src/roslyn`
*[dotnet/roslyn@f8e3bc1](https://github.com/dotnet/roslyn/tree/f8e3bc15401c30630c4dadf0c851f377312811d4)*
*[dotnet/roslyn@cbca41c](https://github.com/dotnet/roslyn/tree/cbca41cad4e21c29548e9e57d7135740b6f78df9)*
- `src/roslyn-analyzers`
*[dotnet/roslyn-analyzers@22a5b5a](https://github.com/dotnet/roslyn-analyzers/tree/22a5b5af1a402fbba34dfbbdeadeb5aa571d008e)*
- `src/runtime`
*[dotnet/runtime@9e6ba1f](https://github.com/dotnet/runtime/tree/9e6ba1f68c6a9c7206dacdf1e4cac67ea19931eb)*
- `src/scenario-tests`
*[dotnet/scenario-tests@bfde902](https://github.com/dotnet/scenario-tests/tree/bfde902a10d7b672f4fc7e844198ede405dbb9c6)*
- `src/sdk`
*[dotnet/sdk@341421c](https://github.com/dotnet/sdk/tree/341421cb1fd159d4a8f6e4f5a9bd4ffe12eb7999)*
*[dotnet/sdk@ce612a3](https://github.com/dotnet/sdk/tree/ce612a3c09a254cc6f437380303e414f948470b3)*
- `src/source-build-externals`
*[dotnet/source-build-externals@3167c0a](https://github.com/dotnet/source-build-externals/tree/3167c0a9379f52145af31057aca31f45528eb123)*
- `src/source-build-externals/src/abstractions-xunit`
Expand Down
26 changes: 13 additions & 13 deletions prereqs/git-info/AllRepoVersions.props
Original file line number Diff line number Diff line change
Expand Up @@ -19,26 +19,26 @@
<emsdkOutputPackageVersion>9.0.0-preview.3.24171.4</emsdkOutputPackageVersion>
<formatGitCommitHash>06fb492cb53e558598e9bf5ee4dd09acc5888a01</formatGitCommitHash>
<formatOutputPackageVersion>9.0.517501</formatOutputPackageVersion>
<fsharpGitCommitHash>4a394198efadc455334ae272954ece372aea4de2</fsharpGitCommitHash>
<fsharpOutputPackageVersion>8.0.300-beta.24175.1</fsharpOutputPackageVersion>
<installerGitCommitHash>09d6f381e6917ee70cf6cbc6109c675c4a51bf77</installerGitCommitHash>
<fsharpGitCommitHash>20b263ab495669df94b309fce12584b207dc765c</fsharpGitCommitHash>
<fsharpOutputPackageVersion>8.0.300-beta.24178.1</fsharpOutputPackageVersion>
<installerGitCommitHash>81f61d829031f71887c49938993e8e2c4cc1eb70</installerGitCommitHash>
<installerOutputPackageVersion>9.0.100</installerOutputPackageVersion>
<msbuildGitCommitHash>89b42a486cf83aa08780da10c4b41f95db9fd60d</msbuildGitCommitHash>
<msbuildOutputPackageVersion>17.10.0-preview-24175-03</msbuildOutputPackageVersion>
<nugetclientGitCommitHash>1845d6bd450a7453d573035371c9fec43683d1ef</nugetclientGitCommitHash>
<nugetclientOutputPackageVersion>6.10.0-preview.2.81</nugetclientOutputPackageVersion>
<razorGitCommitHash>0294056d5b40faada727e267ec6e44150d199b71</razorGitCommitHash>
<razorOutputPackageVersion>7.0.0-preview.24175.1</razorOutputPackageVersion>
<msbuildGitCommitHash>7ca3c98fad986066bbf2802c863236b4a0f4e34a</msbuildGitCommitHash>
<msbuildOutputPackageVersion>17.11.0-preview-24178-16</msbuildOutputPackageVersion>
<nugetclientGitCommitHash>fb50d1a45ed10b39b5f335bc3a4bdcaea9b951cf</nugetclientGitCommitHash>
<nugetclientOutputPackageVersion>6.10.0-preview.2.97</nugetclientOutputPackageVersion>
<razorGitCommitHash>464030ffb65aba45250a1c200bc3528d5dd7a430</razorGitCommitHash>
<razorOutputPackageVersion>7.0.0-preview.24178.6</razorOutputPackageVersion>
<roslynanalyzersGitCommitHash>22a5b5af1a402fbba34dfbbdeadeb5aa571d008e</roslynanalyzersGitCommitHash>
<roslynanalyzersOutputPackageVersion>3.11.0-beta1.24165.2</roslynanalyzersOutputPackageVersion>
<roslynGitCommitHash>f8e3bc15401c30630c4dadf0c851f377312811d4</roslynGitCommitHash>
<roslynOutputPackageVersion>4.10.0-3.24175.5</roslynOutputPackageVersion>
<roslynGitCommitHash>cbca41cad4e21c29548e9e57d7135740b6f78df9</roslynGitCommitHash>
<roslynOutputPackageVersion>4.10.0-3.24202.15</roslynOutputPackageVersion>
<runtimeGitCommitHash>9e6ba1f68c6a9c7206dacdf1e4cac67ea19931eb</runtimeGitCommitHash>
<runtimeOutputPackageVersion>9.0.0-preview.3.24172.9</runtimeOutputPackageVersion>
<scenariotestsGitCommitHash>bfde902a10d7b672f4fc7e844198ede405dbb9c6</scenariotestsGitCommitHash>
<scenariotestsOutputPackageVersion>9.0.0-preview.24057.2</scenariotestsOutputPackageVersion>
<sdkGitCommitHash>341421cb1fd159d4a8f6e4f5a9bd4ffe12eb7999</sdkGitCommitHash>
<sdkOutputPackageVersion>9.0.100-preview.3.24175.20</sdkOutputPackageVersion>
<sdkGitCommitHash>ce612a3c09a254cc6f437380303e414f948470b3</sdkGitCommitHash>
<sdkOutputPackageVersion>9.0.100-preview.3.24204.14</sdkOutputPackageVersion>
<sourcebuildexternalsGitCommitHash>3167c0a9379f52145af31057aca31f45528eb123</sourcebuildexternalsGitCommitHash>
<sourcebuildexternalsOutputPackageVersion>9.0.0-alpha.1.24162.1</sourcebuildexternalsOutputPackageVersion>
<sourcebuildreferencepackagesGitCommitHash>c0b5d69a1a1513528c77fffff708c7502d57c35c</sourcebuildreferencepackagesGitCommitHash>
Expand Down
6 changes: 3 additions & 3 deletions prereqs/git-info/fsharp.props
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<GitCommitHash>4a394198efadc455334ae272954ece372aea4de2</GitCommitHash>
<OfficialBuildId>20240325.1</OfficialBuildId>
<OutputPackageVersion>8.0.300-beta.24175.1</OutputPackageVersion>
<GitCommitHash>20b263ab495669df94b309fce12584b207dc765c</GitCommitHash>
<OfficialBuildId>20240328.1</OfficialBuildId>
<OutputPackageVersion>8.0.300-beta.24178.1</OutputPackageVersion>
<PreReleaseVersionLabel>beta</PreReleaseVersionLabel>
<IsStable>false</IsStable>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions prereqs/git-info/installer.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<GitCommitHash>09d6f381e6917ee70cf6cbc6109c675c4a51bf77</GitCommitHash>
<OfficialBuildId>20240325.1</OfficialBuildId>
<GitCommitHash>81f61d829031f71887c49938993e8e2c4cc1eb70</GitCommitHash>
<OfficialBuildId>20240404.1</OfficialBuildId>
<OutputPackageVersion>9.0.100</OutputPackageVersion>
<PreReleaseVersionLabel></PreReleaseVersionLabel>
<IsStable>true</IsStable>
Expand Down
6 changes: 3 additions & 3 deletions prereqs/git-info/msbuild.props
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<GitCommitHash>89b42a486cf83aa08780da10c4b41f95db9fd60d</GitCommitHash>
<OfficialBuildId>20240325.3</OfficialBuildId>
<OutputPackageVersion>17.10.0-preview-24175-03</OutputPackageVersion>
<GitCommitHash>7ca3c98fad986066bbf2802c863236b4a0f4e34a</GitCommitHash>
<OfficialBuildId>20240328.16</OfficialBuildId>
<OutputPackageVersion>17.11.0-preview-24178-16</OutputPackageVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<IsStable>false</IsStable>
</PropertyGroup>
Expand Down
6 changes: 3 additions & 3 deletions prereqs/git-info/nuget-client.props
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<GitCommitHash>1845d6bd450a7453d573035371c9fec43683d1ef</GitCommitHash>
<OfficialBuildId>20240321.1</OfficialBuildId>
<OutputPackageVersion>6.10.0-preview.2.81</OutputPackageVersion>
<GitCommitHash>fb50d1a45ed10b39b5f335bc3a4bdcaea9b951cf</GitCommitHash>
<OfficialBuildId>20240404.1</OfficialBuildId>
<OutputPackageVersion>6.10.0-preview.2.97</OutputPackageVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<IsStable>false</IsStable>
</PropertyGroup>
Expand Down
6 changes: 3 additions & 3 deletions prereqs/git-info/razor.props
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<GitCommitHash>0294056d5b40faada727e267ec6e44150d199b71</GitCommitHash>
<OfficialBuildId>20240325.1</OfficialBuildId>
<OutputPackageVersion>7.0.0-preview.24175.1</OutputPackageVersion>
<GitCommitHash>464030ffb65aba45250a1c200bc3528d5dd7a430</GitCommitHash>
<OfficialBuildId>20240328.6</OfficialBuildId>
<OutputPackageVersion>7.0.0-preview.24178.6</OutputPackageVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<IsStable>false</IsStable>
</PropertyGroup>
Expand Down
6 changes: 3 additions & 3 deletions prereqs/git-info/roslyn.props
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<GitCommitHash>f8e3bc15401c30630c4dadf0c851f377312811d4</GitCommitHash>
<OfficialBuildId>20240325.5</OfficialBuildId>
<OutputPackageVersion>4.10.0-3.24175.5</OutputPackageVersion>
<GitCommitHash>cbca41cad4e21c29548e9e57d7135740b6f78df9</GitCommitHash>
<OfficialBuildId>20240402.15</OfficialBuildId>
<OutputPackageVersion>4.10.0-3.24202.15</OutputPackageVersion>
<PreReleaseVersionLabel>3</PreReleaseVersionLabel>
<IsStable>false</IsStable>
</PropertyGroup>
Expand Down
6 changes: 3 additions & 3 deletions prereqs/git-info/sdk.props
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<GitCommitHash>341421cb1fd159d4a8f6e4f5a9bd4ffe12eb7999</GitCommitHash>
<OfficialBuildId>20240325.20</OfficialBuildId>
<OutputPackageVersion>9.0.100-preview.3.24175.20</OutputPackageVersion>
<GitCommitHash>ce612a3c09a254cc6f437380303e414f948470b3</GitCommitHash>
<OfficialBuildId>20240404.14</OfficialBuildId>
<OutputPackageVersion>9.0.100-preview.3.24204.14</OutputPackageVersion>
<PreReleaseVersionLabel>preview.3</PreReleaseVersionLabel>
<IsStable>false</IsStable>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/fsharp/DEVGUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ Running any of the above will build the latest changes and run tests against the

## Using your custom compiler to build this repository

By removing all the subfolders called `Proto` under `artifacts` and running the `build` script again, the proto compiler will include your changes.
By removing all the subfolders called `Bootstrap` or `Proto` under `artifacts` and running the `build` script again, the proto compiler will include your changes.

Once the "proto" compiler is built, it won't be built again, so you may want to perform those steps again to ensure your changes don't break building the compiler itself.

Expand Down
30 changes: 30 additions & 0 deletions src/fsharp/VisualFSharp.sln
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FSharp.Editor.IntegrationTe
EndProject
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "FSharp.Benchmarks.Common", "tests\benchmarks\FSharp.Benchmarks.Common\FSharp.Benchmarks.Common.fsproj", "{6734FC6F-B5F3-45E1-9A72-720378BB49C9}"
EndProject
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "MicroPerf", "tests\benchmarks\CompiledCodeBenchmarks\MicroPerf\MicroPerf.fsproj", "{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MicroPerfCSharp", "tests\benchmarks\CompiledCodeBenchmarks\MicroPerf\CS\MicroPerfCSharp.csproj", "{9F9DD315-37DA-4413-928E-1CFC6924B64F}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -1005,6 +1009,30 @@ Global
{6734FC6F-B5F3-45E1-9A72-720378BB49C9}.Release|Any CPU.Build.0 = Release|Any CPU
{6734FC6F-B5F3-45E1-9A72-720378BB49C9}.Release|x86.ActiveCfg = Release|Any CPU
{6734FC6F-B5F3-45E1-9A72-720378BB49C9}.Release|x86.Build.0 = Release|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Debug|Any CPU.Build.0 = Debug|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Debug|x86.ActiveCfg = Debug|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Debug|x86.Build.0 = Debug|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Proto|Any CPU.ActiveCfg = Debug|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Proto|Any CPU.Build.0 = Debug|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Proto|x86.ActiveCfg = Debug|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Proto|x86.Build.0 = Debug|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Release|Any CPU.ActiveCfg = Release|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Release|Any CPU.Build.0 = Release|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Release|x86.ActiveCfg = Release|Any CPU
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213}.Release|x86.Build.0 = Release|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Debug|Any CPU.Build.0 = Debug|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Debug|x86.ActiveCfg = Debug|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Debug|x86.Build.0 = Debug|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Proto|Any CPU.ActiveCfg = Debug|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Proto|Any CPU.Build.0 = Debug|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Proto|x86.ActiveCfg = Debug|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Proto|x86.Build.0 = Debug|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Release|Any CPU.ActiveCfg = Release|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Release|Any CPU.Build.0 = Release|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Release|x86.ActiveCfg = Release|Any CPU
{9F9DD315-37DA-4413-928E-1CFC6924B64F}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -1084,6 +1112,8 @@ Global
{CBC96CC7-65AB-46EA-A82E-F6A788DABF80} = {F7876C9B-FB6A-4EFB-B058-D6967DB75FB2}
{E31F9B59-FCF1-4D04-8762-C7BB60285A7B} = {F7876C9B-FB6A-4EFB-B058-D6967DB75FB2}
{6734FC6F-B5F3-45E1-9A72-720378BB49C9} = {DFB6ADD7-3149-43D9-AFA0-FC4A818B472B}
{601CD5C1-EAFA-4AE3-8FB9-F667B5728213} = {DFB6ADD7-3149-43D9-AFA0-FC4A818B472B}
{9F9DD315-37DA-4413-928E-1CFC6924B64F} = {DFB6ADD7-3149-43D9-AFA0-FC4A818B472B}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {48EDBBBE-C8EE-4E3C-8B19-97184A487B37}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
### Fixed

* Fix a false positive of the `[<TailCall>]` analysis in combination with `yield!`. ([PR #16933](https://github.com/dotnet/fsharp/pull/16933))
* Don't blow the stack when traversing deeply nested sequential expressions. ([PR #16882](https://github.com/dotnet/fsharp/pull/16882))
* Fix wrong range start of INTERP_STRING_END. ([PR #16774](https://github.com/dotnet/fsharp/pull/16774), [PR #16785](https://github.com/dotnet/fsharp/pull/16785))
* Fix missing warning for recursive calls in list comprehensions. ([PR #16652](https://github.com/dotnet/fsharp/pull/16652))
Expand Down Expand Up @@ -35,11 +36,13 @@
* Parser recovers on complex primary constructor patterns, better tree representation for primary constructor patterns. ([PR #16425](https://github.com/dotnet/fsharp/pull/16425))
* Name resolution: keep type vars in subsequent checks ([PR #16456](https://github.com/dotnet/fsharp/pull/16456))
* Higher-order-function-based API for working with the untyped abstract syntax tree. ([PR #16462](https://github.com/dotnet/fsharp/pull/16462))
* PrettyNaming: make `DoesIdentifierNeedBackticks` public ([PR #16613](https://github.com/dotnet/fsharp/pull/16613))
* Add switch to generate types and members with IL visibility that accurately represents their F# visibility. ([PR #15484](https://github.com/dotnet/fsharp/pull/15484)
* Allow returning bool instead of unit option for partial active patterns. ([Language suggestion #1041](https://github.com/fsharp/fslang-suggestions/issues/1041), [PR #16473](https://github.com/dotnet/fsharp/pull/16473))
* Symbols: Add GenericArguments to FSharpEntity ([PR #16470](https://github.com/dotnet/fsharp/pull/16470))
* Parser: more 'as' pattern recovery ([PR #16837](https://github.com/dotnet/fsharp/pull/16837))
* Add extended data for `DefinitionsInSigAndImplNotCompatibleAbbreviationsDiffer` (FS0318). ([PR #16811](https://github.com/dotnet/fsharp/pull/16811)))
* Checker/patterns: recover on unresolved long identifiers ([PR #16842](https://github.com/dotnet/fsharp/pull/16842))

### Changed

Expand Down
4 changes: 2 additions & 2 deletions src/fsharp/eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.24165.4">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.24176.8">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>f311667e0587f19c3fa9553a909975662107a351</Sha>
<Sha>48e9e0d2164de0535446809364724da8962123a6</Sha>
<SourceBuild RepoName="arcade" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.23475.1" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
Expand Down
3 changes: 2 additions & 1 deletion src/fsharp/eng/common/templates-official/job/job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,15 @@ jobs:

- ${{ if and(eq(parameters.runAsPublic, 'false'), ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
- ${{ if eq(parameters.enableMicrobuild, 'true') }}:
- task: MicroBuildSigningPlugin@3
- task: MicroBuildSigningPlugin@4
displayName: Install MicroBuild plugin
inputs:
signType: $(_SignType)
zipSources: false
feedSource: https://dnceng.pkgs.visualstudio.com/_packaging/MicroBuildToolset/nuget/v3/index.json
env:
TeamName: $(_TeamName)
MicroBuildOutputFolderOverride: '$(Agent.TempDirectory)'
continueOnError: ${{ parameters.continueOnError }}
condition: and(succeeded(), in(variables['_SignType'], 'real', 'test'), eq(variables['Agent.Os'], 'Windows_NT'))

Expand Down
2 changes: 1 addition & 1 deletion src/fsharp/global.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"perl": "5.38.0.1"
},
"msbuild-sdks": {
"Microsoft.DotNet.Arcade.Sdk": "8.0.0-beta.24165.4",
"Microsoft.DotNet.Arcade.Sdk": "8.0.0-beta.24176.8",
"Microsoft.DotNet.Helix.Sdk": "8.0.0-beta.23255.2"
}
}
6 changes: 5 additions & 1 deletion src/fsharp/src/Compiler/Checking/CheckPatterns.fs
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,11 @@ and TcPat warnOnUpper (cenv: cenv) env valReprInfo vFlags (patEnv: TcPatLinearEn
TcPatAnds warnOnUpper cenv env vFlags patEnv ty pats m

| SynPat.LongIdent (longDotId=longDotId; typarDecls=tyargs; argPats=args; accessibility=vis; range=m) ->
TcPatLongIdent warnOnUpper cenv env ad valReprInfo vFlags patEnv ty (longDotId, tyargs, args, vis, m)
try
TcPatLongIdent warnOnUpper cenv env ad valReprInfo vFlags patEnv ty (longDotId, tyargs, args, vis, m)
with RecoverableException e ->
errorRecovery e m
(fun _ -> TPat_error m), patEnv

| SynPat.QuoteExpr(_, m) ->
errorR (Error(FSComp.SR.tcInvalidPattern(), m))
Expand Down
7 changes: 7 additions & 0 deletions src/fsharp/src/Compiler/Checking/TailCallChecks.fs
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,13 @@ and CheckCall cenv args ctxts (tailCall: TailCall) =
| Expr.App _ -> Some(TailCall.YesFromExpr cenv.g e)
| IsAppInLambdaBody t -> Some t
| _ -> None
| Expr.App(args = args) ->
args
|> List.tryPick (fun a ->
match a with
| IsAppInLambdaBody t -> Some t
| _ -> None)

| _ -> None

// if we haven't already decided this is no tail call, try to detect CPS-like expressions
Expand Down
2 changes: 1 addition & 1 deletion src/fsharp/src/Compiler/SyntaxTree/PrettyNaming.fsi
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ val IsIdentifierName: name: string -> bool
/// TBD: needs unit testing
val IsActivePatternName: name: string -> bool

val internal DoesIdentifierNeedBackticks: string -> bool
val DoesIdentifierNeedBackticks: string -> bool

/// Adds double backticks if necessary to make a valid identifier, e.g.
/// op_Addition --> op_Addition
Expand Down

0 comments on commit dd82ae7

Please sign in to comment.