Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the summary of Control.DefaultPadding in Control.xml #9852

Merged
merged 2 commits into from
May 24, 2024

Conversation

zxcv1050135042
Copy link
Contributor

Missing "default" in summary can easily lead to misunderstandings with Control.Padding

Missing "default" in summary can easily lead to misunderstandings with Control.Padding
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 24, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-WinForms Issues or PRs that relate to WinForms. label Apr 24, 2024
Copy link

Learn Build status updates of commit 295bcb8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows.Forms/Control.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the value as well?

xml/System.Windows.Forms/Control.xml Show resolved Hide resolved
zxcv1050135042

This comment was marked as duplicate.

@gewarren gewarren enabled auto-merge (squash) May 24, 2024 18:27
Copy link

Learn Build status updates of commit 5fda469:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows.Forms/Control.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit c915d9d into dotnet:main May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-WinForms Issues or PRs that relate to WinForms. community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants