Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumbs #9502

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Fix breadcrumbs #9502

wants to merge 9 commits into from

Conversation

raprice
Copy link
Contributor

@raprice raprice commented Dec 7, 2023

Summary

This PR brings breadcrumb implementation into alignment with platform architecture requirements. This PR is part of a previously announced batch of breadcrumb fixes across the Learn platform and will be auto-merged if there are no build warnings. This PR may include removing the “extend breadcrumb” feature from any docfx files that are still using it, fixing breadcrumb file references in the docfx file, and rewriting breadcrumb files to match the approved breadcrumb pattern for a given product’s documentation.

Fixes #Issue_Number (if available)

@raprice raprice requested a review from a team as a code owner December 7, 2023 21:11
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 7, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Dec 7, 2023
gewarren
gewarren previously approved these changes Dec 7, 2023
Copy link

Learn Build status updates of commit a643321:

✅ Validation status: passed

File Status Preview URL Details
breadcrumb/toc.yml ✅Succeeded n/a (file deleted or renamed)
docfx.json ✅Succeeded
dotnet-api-docs-breadcrumb/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@raprice
Copy link
Contributor Author

raprice commented Dec 7, 2023

Troubleshooting, please do not merge yet.

@gewarren
Copy link
Contributor

gewarren commented Dec 7, 2023

@raprice Perhaps convert it to a draft PR then?

@raprice raprice marked this pull request as draft December 7, 2023 22:15
Copy link

Learn Build status updates of commit 3a8d557:

✅ Validation status: passed

File Status Preview URL Details
breadcrumb/toc.yml ✅Succeeded n/a (file deleted or renamed)
docfx.json ✅Succeeded
dotnet-api-docs-breadcrumb/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2c4aec4:

✅ Validation status: passed

File Status Preview URL Details
breadcrumb/toc.yml ✅Succeeded n/a (file deleted or renamed)
docfx.json ✅Succeeded
dotnet-api-docs-breadcrumb/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 6233190:

✅ Validation status: passed

File Status Preview URL Details
breadcrumb/dotnet-api-docs/toc.yml ✅Succeeded
breadcrumb/toc.yml ✅Succeeded n/a (file deleted or renamed)
docfx.json ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit ca3b42c:

✅ Validation status: passed

File Status Preview URL Details
breadcrumb/dotnet-api-docs/toc.yml ✅Succeeded
breadcrumb/toc.yml ✅Succeeded n/a (file deleted or renamed)
docfx.json ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit b468748:

✅ Validation status: passed

File Status Preview URL Details
breadcrumb/toc.yml ✅Succeeded n/a (file deleted or renamed)
docfx.json ✅Succeeded
dotnet-api-docs-bc/breadcrumb/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 039c521:

✅ Validation status: passed

File Status Preview URL Details
breadcrumb/toc.yml ✅Succeeded n/a (file deleted or renamed)
docfx.json ✅Succeeded
dotnet-api-docs-bc/breadcrumb/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren dismissed their stale review May 24, 2024 18:27

Still in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants