Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FileStream.Position breaking change #40776

Merged
merged 2 commits into from May 9, 2024
Merged

Update FileStream.Position breaking change #40776

merged 2 commits into from May 9, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 6, 2024 •
edited by github-actions bot

@gewarren gewarren requested review from adamsitnik and a team May 6, 2024 21:26
@dotnet-bot dotnet-bot added this to the May 2024 milestone May 6, 2024
BillWagner
BillWagner approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Once you're happy with the changes, let's :shipit:

@gewarren gewarren merged commit 2e0cedb into dotnet:main May 9, 2024
8 checks passed
@gewarren gewarren deleted the filestream-position branch May 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

FileStream.Position breaking change documentation should be deleted
3 participants
@gewarren @BillWagner @dotnet-bot