This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Enable hosted builds on arm64 #7696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omajid
force-pushed
the
hosted-arm64-build
branch
2 times, most recently
from
3dc5d66
to
2b71679
Compare
omajid
changed the title
omajid
force-pushed
the
hosted-arm64-build
branch
2 times, most recently
from
9b7c172
to
b957d52
Compare
omajid
changed the title
|
cc @dagood |
dagood
approved these changes
Aug 14, 2019
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide the HostArch. Use that
as the default value of TargetArchitecture, unless another value was
provided by the build configuration.
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to pick the normal-RID
(eg, linux-arm64) libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes #7653
omajid
force-pushed
the
hosted-arm64-build
branch
from
b957d52
to
6a9b9ba
Compare
|
Even better. 😄 Thanks again. |
|
Thanks for the review and merging this! |
omajid
added a commit
to omajid/dotnet-installer
that referenced
this pull request
Aug 19, 2019
With this commit, I can build core-sdk on RHEL 8 on arm64 directly, without cross compilation. Bump the sourcelink version to pick up the ability to parse git info without depending on libgit2sharp. This allows sourcelink to work on arm64. The version is the same as the one recently added to core-setup: dotnet/core-setup#7696 Introduce a new 'HostArch' msbuild property that contains the host architecture (arm64, x64, etc). This is the architecture of the currently running machine, and may be different from the architecture we are targetting in the case of cross compilation. Use HostArch to determine whether _crossDir and LibCLRJitRid need to be special-cased for arm64 or or not.
|
@dagood It looks like this broke tests via VS in corefx: dotnet/corefx#40427 Do we want to revert it here in core-setup as well? |
|
That's a shame, I suppose we should. 😕 Thanks for pinging this thread about it. FYI @vitek-karas, @elinor-fung if you've had problems building tests in VS recently. |
omajid
added a commit
to omajid/dotnet-installer
that referenced
this pull request
Aug 20, 2019
With this commit, I can build core-sdk on RHEL 8 on arm64 directly, without cross compilation. Bump the sourcelink version to pick up the ability to parse git info without depending on libgit2sharp. This allows sourcelink to work on arm64. The version is the same as the one recently added to core-setup: dotnet/core-setup#7696 Introduce a new 'HostArch' msbuild property that contains the host architecture (arm64, x64, etc). This is the architecture of the currently running machine, and may be different from the architecture we are targetting in the case of cross compilation. There's a gotcha with HostArch: under Visual Studio (an x86) process, we generally want a x64 architecture. Use HostArch to determine whether _crossDir and LibCLRJitRid need to be special-cased for arm64 or or not.
|
Can we please revert this? Among other things this makes default command line build on Windows to produce x86 (unlike x64 which it did before) - this breaks all my links and so on, and it's not the default we want anyway. |
omajid
added a commit
to omajid/dotnet-core-setup
that referenced
this pull request
Aug 22, 2019
This reverts commit 4b82b1e. The changes break VS and may even change the default on Windows to x86 instead of x64.
|
I opened #7806 to revert this change |
dagood
pushed a commit
that referenced
this pull request
Aug 22, 2019
omajid
added a commit
to omajid/dotnet-installer
that referenced
this pull request
Oct 9, 2019
With this commit, I can build core-sdk on RHEL 8 on arm64 directly, without cross compilation. Bump the sourcelink version to pick up the ability to parse git info without depending on libgit2sharp. This allows sourcelink to work on arm64. The version is the same as the one recently added to core-setup: dotnet/core-setup#7696 Introduce a new 'BuildArchitecture' msbuild property that contains the host architecture (arm64, x64, etc). This is the architecture of the currently running machine, and may be different from the architecture we are targetting in the case of cross compilation. There's a gotcha with BuildArchitecture: under Visual Studio (an x86) process, we generally want a x64 architecture. So try and restrict it to arm64 only. Use BuildArchitecture to determine whether _crossDir and LibCLRJitRid need to be special-cased for arm64 or or not.
omajid
added a commit
to omajid/dotnet-installer
that referenced
this pull request
Oct 17, 2019
With this commit, I can build core-sdk on RHEL 8 on arm64 directly, without cross compilation. Bump the sourcelink version to pick up the ability to parse git info without depending on libgit2sharp. This allows sourcelink to work on arm64. The version is the same as the one recently added to core-setup: dotnet/core-setup#7696 Introduce a new 'BuildArchitecture' msbuild property that contains the host architecture (arm64, x64, etc). This is the architecture of the currently running machine, and may be different from the architecture we are targetting in the case of cross compilation. There's a gotcha with BuildArchitecture: under Visual Studio (an x86) process, we generally want a x64 architecture. So try and restrict it to arm64 only. Use BuildArchitecture to determine whether _crossDir and LibCLRJitRid need to be special-cased for arm64 or or not.
omajid
added a commit
to omajid/dotnet-installer
that referenced
this pull request
Oct 31, 2019
With this commit, I can build core-sdk on RHEL 8 on arm64 directly, without cross compilation. Bump the sourcelink version to pick up the ability to parse git info without depending on libgit2sharp. This allows sourcelink to work on arm64. The version is the same as the one recently added to core-setup: dotnet/core-setup#7696 Introduce a new 'BuildArchitecture' msbuild property that contains the host architecture (arm64, x64, etc). This is the architecture of the currently running machine, and may be different from the architecture we are targetting in the case of cross compilation. There's a gotcha with BuildArchitecture: under Visual Studio (an x86) process, we generally want a x64 architecture. So try and restrict it to arm64 only. Use BuildArchitecture to determine whether _crossDir and LibCLRJitRid need to be special-cased for arm64 or or not.
dagood
pushed a commit
to dotnet/installer
that referenced
this pull request
Nov 7, 2019
With this commit, I can build core-sdk on RHEL 8 on arm64 directly, without cross compilation. Bump the sourcelink version to pick up the ability to parse git info without depending on libgit2sharp. This allows sourcelink to work on arm64. The version is the same as the one recently added to core-setup: dotnet/core-setup#7696 Introduce a new 'BuildArchitecture' msbuild property that contains the host architecture (arm64, x64, etc). This is the architecture of the currently running machine, and may be different from the architecture we are targetting in the case of cross compilation. There's a gotcha with BuildArchitecture: under Visual Studio (an x86) process, we generally want a x64 architecture. So try and restrict it to arm64 only. Use BuildArchitecture to determine whether _crossDir and LibCLRJitRid need to be special-cased for arm64 or or not.
dagood
pushed a commit
to dagood/installer
that referenced
this pull request
Feb 21, 2020
With this commit, I can build core-sdk on RHEL 8 on arm64 directly, without cross compilation. Bump the sourcelink version to pick up the ability to parse git info without depending on libgit2sharp. This allows sourcelink to work on arm64. The version is the same as the one recently added to core-setup: dotnet/core-setup#7696 Introduce a new 'BuildArchitecture' msbuild property that contains the host architecture (arm64, x64, etc). This is the architecture of the currently running machine, and may be different from the architecture we are targetting in the case of cross compilation. There's a gotcha with BuildArchitecture: under Visual Studio (an x86) process, we generally want a x64 architecture. So try and restrict it to arm64 only. Use BuildArchitecture to determine whether _crossDir and LibCLRJitRid need to be special-cased for arm64 or or not.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide the HostArch. Use that
as the default value of TargetArchitecture, unless another value was
provided by the build configuration.
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to pick the normal-RID
(eg, linux-arm64) libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes dotnet/core-setup#7653
Commit migrated from dotnet/core-setup@4b82b1e
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…et/core-setup#7806) This reverts commit dotnet/core-setup@4b82b1e. The changes break VS and may even change the default on Windows to x86 instead of x64. Commit migrated from dotnet/core-setup@a307f0d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable building core-setup on arm64 (hosted, not cross compiled), we need to do a few things:
Set the right
TargetArchitectureUse the currently running architecture to decide whether to default to
x64or to switch toarm64whenTargetArchitectureis not specifiedUse the right coreclr JIT
If we are cross-compiling, we need to use the
x86_arm64libclrjit.so. But if we are building on an arm64 host, we need to filter the list of foundlibclrjit.sofiles to pick the normal-RID (eg,linux-arm64)libclrjit.sofrom the two:./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/5.0.0-alpha1.19403.2/runtimes/linux-arm64/native/libclrjit.so./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/5.0.0-alpha1.19403.2/runtimes/x64_arm64/native/libclrjit.soUse a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains Initial implementation of direct git repo data reading sourcelink#288. This commit just updates it to the latest version.
Fixes #7653