Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in APIBaselines.md #55393

Merged
merged 1 commit into from Apr 29, 2024
Merged

Fix typos in APIBaselines.md #55393

merged 1 commit into from Apr 29, 2024

Conversation

GiovanniBraconi
Copy link
Contributor

@GiovanniBraconi GiovanniBraconi commented Apr 27, 2024 •
edited

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Fixes some typos in APIBaselines.md

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 27, 2024
mkArtakMSFT
mkArtakMSFT approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GiovanniBraconi !

@mkArtakMSFT mkArtakMSFT self-assigned this Apr 28, 2024
danmoseley
danmoseley approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@danmoseley danmoseley enabled auto-merge (squash) April 28, 2024 01:24
@captainsafia
Copy link
Member

@dotnet/aspnet-build Can someone with permissions force-merge this? Test failures are unrelated.

@wtgodbe wtgodbe disabled auto-merge April 29, 2024 16:48
@wtgodbe wtgodbe merged commit 3f68a51 into dotnet:main Apr 29, 2024
19 of 22 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmoseley danmoseley danmoseley approved these changes

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees

@mkArtakMSFT mkArtakMSFT

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0-preview5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GiovanniBraconi @captainsafia @danmoseley @mkArtakMSFT @wtgodbe