New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the baggage even when the trace id is not successfully extracted #55341
base: main
Are you sure you want to change the base?
Conversation
Thanks for your PR, @joegoldman2. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some basic questions.
@@ -535,10 +535,39 @@ public void ActivityBaggageReadFromLegacyHeaders() | |||
features.Set<IHttpRequestFeature>(new HttpRequestFeature() | |||
{ | |||
Headers = new HeaderDictionary() | |||
{ | |||
{"baggage", "Key1=value1, Key2=value2"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not having a request id here exercises the new code (thanks!), but is it something that could plausibly happen? This question may be terribly naive - I'm not very familiar with distributed tracing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's possible. Not all frameworks set it. This is not the case with .NET because HttpClient
sets it (https://github.com/dotnet/runtime/blob/33a68d0cef067034df5cbac89415568e5fda63ce/src/libraries/System.Net.Http/src/System/Net/Http/DiagnosticsHandler.cs#L308) but someone can use another framework (or make the request manually via curl, Postman, or whatever) and in this case there will be no request id (traceparent
) in the request (ASP.NET will generate one in this case).
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Fixes #50158.
Better to review it without whitespace diff: https://github.com/dotnet/aspnetcore/pull/55341/files?diff=unified&w=1.