Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnixCertificateManager: implement IsTrusted. #55335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UnixCertificateManager: implement IsTrusted. #55335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Shared/CertificateGeneration/UnixCertificateManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ internal UnixCertificateManager(string subject, int version)
{
}

public override bool IsTrusted(X509Certificate2 certificate) => false;
public override bool IsTrusted(X509Certificate2 certificate)
{
using X509Chain chain = new X509Chain();
chain.ChainPolicy.RevocationMode = X509RevocationMode.NoCheck;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable revocation checking? Perf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X509Chain uses Online as the default and SocketsHttpHandler uses NoCheck as the default.

If we don't set this to NoCheck then verification fails because the local certificates have no online revocation list to check against.

return chain.Build(certificate);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason not to use the logic on all platforms? It looks like on Windows we check for the cert in new X509Store(StoreName.Root, StoreLocation.CurrentUser) specifically and on macOS we use security verify-cert -p basic -p ssl on the exported dev cert. I'm not sure what advantages either of those things have over this. @javiercn

}

protected override X509Certificate2 SaveCertificateCore(X509Certificate2 certificate, StoreName storeName, StoreLocation storeLocation)
{
Expand Down