Revert "Remove __non_webpack_require__ workaround and split Node dependencies correctly (#48154)"

[BrennanConroy]

This reverts commit 93520b6.
It caused more issues than it solved see #52082

We'll need to reopen #47674 and probably completely redo how we bundle the signalr package so it works better.

Revert "Remove non_webpack_require workaround and split Node dependencies correctly

Description

We made a change to fix some esbuild issues with the signalr npm package. Unfortunately, these changes had unintended side-effects to Angular apps.

Customer Impact

People using Angular 17 have build errors when using the @microsoft/signalr package.
Workarounds are given in #52082 (comment)

Regression?

• Yes
• No

Change in 8.0 to how we referenced external dependencies for node apps. Broke people using Angular 17 (which released after the change).

Risk

• High
• Medium
• Low

Completely reverting a change to how it was for multiple releases so there isn't any real risk. However, it is technically a breaking change when using esbuild. It's sad, but far more people are being affected by the current issue than were fixed by the change. A full fix would likely also be a breaking change as it likely requires reworking how we bundle the package which changes what files are available in the bundled package.

Verification

• Manual

Packaging changes reviewed?

• Yes
• No
• N/A

[dotnet-policy-service]

Hi @BrennanConroy. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[BrennanConroy]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).