[Infrastructure] Add a workflow to validate package-lock.json when changes are introduced. #54688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
Temp remove the paths
Revert previous commit
javiercn
commented
Mar 22, 2024
SteveSandersonMS
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Looks great!
I'm not clear on whether this PR actually validates that the new workflow succeeds, since it only runs the new workflow when package-lock.json is modified, and it's not modified in this PR. Assuming you know the new workflow will succeed in general, LGTM!
javiercn
deleted the
javiercn/validate-package-lock-json-against-upstream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces a check against the azdo feed at the time the changes are introduced