Remove generation of schemas in OpenAPI package #42169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Co-authored-by: Damian Edwards <damian@damianedwards.com>
|
@brunolins16 Mind giving this a review? |
brunolins16
reviewed
Jun 16, 2022
| { | ||
| Schema = OpenApiSchemaGenerator.GetOpenApiSchema(type) | ||
| }; | ||
| responseContent[contentType] = new OpenApiMediaType(); |
There was a problem hiding this comment.
Swashbuckle will now read this information and populate the Schema, is that how it will work?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41246.
Since generating accurate OpenAPI schemas for all DTOs in ✨ big work ✨, we're temporarily removing this from the OpenAPI package and instead opting with a "merge" strategy where we will leverage existing OpenAPI schema support in Swashbuckle.
Long-term, we want to explore more foundational support for generating JSON schemas (which OpenAPI schemas are a derivative of) in either System.Text.Json (ref) or Microsoft.OpenAPI (ref).