Fix Component Governance alerts

[wtgodbe]

Will also need dotnet/spa-templates#47

[dougbu]

If I'm reading this correctly, it looks scary. Does this mean that a package requesting ws v8.2.3 will instead get v7.5.7❔ If yes, is there a way to map v7.x.y to v7.5.7 but still have v8.2.3 map to itself❔

[wtgodbe]

I think it does mean that, and I'm not sure if there's a way to achieve that. I'm trying ^ here because I've run into problems with resolving versions using >= as that often updates things too much and leads to build breaks.

[wtgodbe]

Updated to use >= instead of ^, after looking at other branches I'm thinking that >= breaks things less often than I'd thought.

[dougbu]

I guess this is better but now the 7.x.y dependencies are getting updated across a major version boundary. @BrennanConroy is JS testing enough to catch any problems that may cause❔

[BrennanConroy]

This version is only used for a single test AFAIK and it's sort of a silly test IMO.

The majority of our tests that use WS actually get WS from https://github.com/dotnet/aspnetcore/tree/main/src/SignalR/clients/ts/signalr which is using 7.4.6

[dougbu]

WFM as long as the big ws version bumps definitely don't break anything

[dougbu]

nit: This might as well be >=8.6.0 based on the yarn.lock file

[wtgodbe]

Spa-templates are now updated in this PR (CC @mkArtakMSFT @MackinnonBuck)

[wtgodbe]

@javiercn @MackinnonBuck @HaoK we've got a template test failure after updating dependencies in spa-templates, can you take a look?

Templates.Test.BaselineTest.Template_Produces_The_Right_Set_Of_FilesAsync(arguments: "new react", expectedFiles: ["ClientApp/public/favicon.ico", "ClientApp/public/index.html", "ClientApp/public/manifest.json", "ClientApp/src/components/Counter.js", "ClientApp/src/components/FetchData.js", ...])

Assert.Contains() Failure
Not found: ClientApp/src/AppRoutes.js
In value: String[] ["ClientApp/public/favicon.ico", "ClientApp/public/index.html", "ClientApp/public/manifest.json", "ClientApp/src/components/Counter.js", "ClientApp/src/components/FetchData.js", ...]

[MackinnonBuck]

@wtgodbe AppRoutes.js was added to the React template as part of the dependency updates, so the baselines just need to be regenerated.

[RichardSunMS]

@wtgodbe, @dougbu, I am having another Governance issue: #41729, can you guys help take a look?

[ghost]

Hi @RichardSunMS. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.