Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Don't exclude System.IO.Pipelines from TargetingPack version check #39303

Merged
merged 1 commit into from Jan 10, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 4, 2022

Backport of #39287 to release/5.0

/cc @wtgodbe

{PR title}

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@github-actions github-actions bot requested a review from Pilchie as a code owner January 4, 2022 17:28
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 4, 2022
@ghost ghost added this to the 5.0.x milestone Jan 4, 2022
@ghost ghost added this to In Progress in Servicing Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@dougbu
Copy link
Member

dougbu commented Jan 7, 2022

@dotnet/aspnet-build it looks like BundlesScopedCssFiles_UpdatesBundleWhenContentsChange() is really flaky in this branch. It's already marked as quarantined but is still failing builds. Who has the most context these days on [QuarantinedTest] and might have ideas why it isn't working in this branch❔

Should we just Skip the test❔

@dougbu
Copy link
Member

dougbu commented Jan 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu
Copy link
Member

dougbu commented Jan 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu
Copy link
Member

dougbu commented Jan 10, 2022

@wtgodbe suggest merging if you think this is ready. Separately, shouldn't this and #39302 be tell-mode

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 10, 2022
@wtgodbe wtgodbe merged commit 68dde4f into release/5.0 Jan 10, 2022
Servicing automation moved this from In Progress to Done Jan 10, 2022
@wtgodbe wtgodbe deleted the backport/pr-39287-to-release/5.0 branch January 10, 2022 19:41
@dougbu dougbu modified the milestones: 5.0.x, 5.0.14 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants