Backport #32277 to 5.0

[TanayParikh]

Description

Update guard logic to permit writing 0 length buffers. This can happen in certain globalized scenarios (ex. ¿ with Portugese) where the first char needs to be encoded.

Patch #31299 for 5.0 by cherry-picking the #32277 squash commit.

Customer Impact

Writing 0-length char buffers leads to an ArgumentOutOfRangeException. This may occur in a globalization context with certain chars such as ¿.

#31299 (comment)

Also impacts Orchard: #31299 (comment)

Regression?

• Yes
• No

[If yes, specify the version the behavior has regressed from]

Risk

• High
• Medium
• Low

Low risk as we've just updated the logic slightly to permit 0 length buffers.

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

Addresses #31299

[ghost]

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

[mkArtakMSFT]

This has been approved by Tactics.

Thanks @TanayParikh!

[Theoistic]

So this was suppose to fix this issue??:

ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'index') Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.ViewBufferTextWriter.Write(char[] buffer, int index, int count) System.IO.TextWriter.Write(ReadOnlySpan<char> buffer) System.IO.TextWriterExtensions.WritePartialString(TextWriter writer, string value, int offset, int count) System.Text.Encodings.Web.TextEncoder.Encode(TextWriter output, string value, int startIndex, int characterCount) Microsoft.AspNetCore.Mvc.Rendering.TagBuilder.AppendAttributes(TextWriter writer, HtmlEncoder encoder) Microsoft.AspNetCore.Mvc.Rendering.TagBuilder.WriteTo(TagBuilder tagBuilder, TextWriter writer, HtmlEncoder encoder, TagRenderMode tagRenderMode)

This last patch broke production, and since this has high-jacked the action setup script on github.
/home/runner/work/_actions/actions/setup-dotnet/v1/externals/install-dotnet.sh --version 5.0.300
Is there like a SUPER fast way to revert this?

[ghost]

Hi @Theoistic. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[Theoistic]

@sebastienros .. fyi
I believe the tests for these changes needs to be broader.

[ghost]

Hi @Theoistic. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[TanayParikh]

Thanks for reaching out @Theoistic. Can you please file a new issue with those details, as well as any other information you may have (input arguments to that function, repro steps, etc.).