Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup site extensions 3.1 versions #31809

Merged
1 commit merged into from Apr 14, 2021
Merged

Fixup site extensions 3.1 versions #31809

1 commit merged into from Apr 14, 2021

Conversation

JunTaoLuo
Copy link
Contributor

This fixes up the version update made in #31773

@JunTaoLuo JunTaoLuo added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 14, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

Hello @dougbu!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@dougbu
Copy link
Member

dougbu commented Apr 14, 2021

Set auto-merge to get this in ASAP. But, @wtgodbe and @JunTaoLuo feel free to merge immediately if starting ASP.NET builds is urgent. The PR build won't validate the change. I'm just not sure how pressed for time we are.

@wtgodbe
Copy link
Member

wtgodbe commented Apr 14, 2021

This is against main, so no rush

@dougbu
Copy link
Member

dougbu commented Apr 14, 2021

Oh, I assumed this was against release/5.0. Does this mean we aren't creating up-to-date site extension bundles for 5.0

We normally do the same thing in that branch though our issue template only mentions "the main copy". IIRC @BrennanConroy suggested doing this in both branches was helpful.

@ghost ghost merged commit 2e30ca1 into main Apr 14, 2021
@ghost ghost deleted the JunTaoLuo-patch-1 branch April 14, 2021 19:44
@wtgodbe
Copy link
Member

wtgodbe commented Apr 14, 2021

Looks like I missed updating the 5.0 version:

<MicrosoftAspNetCoreAzureAppServicesSiteExtension31PackageVersion>3.1.13-servicing-21117-13</MicrosoftAspNetCoreAzureAppServicesSiteExtension31PackageVersion>

I can create that PR now

@wtgodbe
Copy link
Member

wtgodbe commented Apr 14, 2021

#31811

@JunTaoLuo
Copy link
Contributor Author

Can you also update the doc so we remember to update in both branches?

@wtgodbe
Copy link
Member

wtgodbe commented Apr 14, 2021

@dotnet dotnet deleted a comment Apr 14, 2021
@dotnet dotnet deleted a comment Apr 14, 2021
@dotnet dotnet deleted a comment Apr 14, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants