Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make constraint cache thread safe #17146

Merged
merged 2 commits into from Nov 16, 2019
Merged

Make constraint cache thread safe #17146

merged 2 commits into from Nov 16, 2019

Commits on Nov 15, 2019

  1. Make constraint cache thread safe 

    Fixes: #17101

This changes the constraint cache to use ConcurrentDictionary. This code
is invoked in a multithreaded way in Blazor server resulting in internal
failures in dictionary.

Since this is a threading issue there's no good way to unit test it, but
I noticed we're missing tests in general for this class, so I added a
few for the caching behavior.
    @rynowak
    Ryan Nowak authored and rynowak committed Nov 15, 2019
    Copy the full SHA
    7db6395 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    Ryan Nowak committed Nov 15, 2019
    Copy the full SHA
    3c5fd72 View commit details
    Browse the repository at this point in the history