[release/2.2] Backport memory leak fix from 3.0 #13840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Sep 9, 2019
|
@aspnet/build I'm hitting 401s for the windows and mac builds for 2.2. Any idea what is going on? |
|
Need to update the patch config file |
jkotalik
added
the
Servicing-consider
jkotalik
force-pushed
the
jkotalik/22DataProtectionEf
branch
from
ffa827a
to
1368572
Compare
blowdart
approved these changes
Sep 18, 2019
analogrelay
changed the title
analogrelay
added
Servicing-approved
jkotalik
force-pushed
the
jkotalik/22DataProtectionEf
branch
from
1368572
to
b229542
Compare
|
Had to fix merge conflicts, will merge once green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #13743, but for 2.2.
Description
Customers using the Microsoft.AspNetCore.DataProtection.EntityFrameworkCore package would silently hit a memory leak every time EntityFrameworkCoreXmlRepository.GetAllElements is called. Specifically, both the Logger and Services would leak each time this is called.
Customer impact
In 2.2, customers will see increased memory usage everytime they call EntityFrameworkCoreXmlRepository.GetAllElements due to a memory leak.
Regression
No. This behavior has existed since the release of 2.2.
Risk
Low. This changes the call to TryParseKeyXml from an instance method to static.
@Pilchie can you take this to ship room It's the same change as above, but minimized for 2.2.