[3.1] Re-implement SameSite for 2019 #13776
Conversation
Tratcher
changed the title
|
Feels breaking. What's the effect on Cookie Policy here? Shouldn't the underlying cookie quirks be enough? |
|
CookiePolicy also has to account for the new level of "None" vs "Unspecified". I didn't add quirks at the CookiePolicy layer because you're right, that's handled at the SetCookieHeaderValue layer. |
|
Added more quirks for CookiePolicy, etc.. |
Tratcher
force-pushed
the
tratcher/3.1/samesite
branch
from
b3cb06a
to
3e34315
Compare
Tratcher
force-pushed
the
tratcher/3.1/samesite
branch
from
3e34315
to
4462a0a
Compare
|
@anurse this is ready to merge. |
|
This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com. I've triaged the above build. I've created/commented on the following issue(s) |
| { | ||
| if (options.SameSite > SameSiteMode.Unspecified) | ||
| { | ||
| var userAgent = httpContext.Request.Headers["User-Agent"]; |
There was a problem hiding this comment.
var userAgent = httpContext.Request.Headers["User-Agent"].ToString();
There was a problem hiding this comment.
Do you need to make this change in the preview1 build?
There was a problem hiding this comment.
No, it's just a sample, I've corrected it elsewhere. I just wanted to mark the typo so I'd remember it.
amcasey
added
area-networking
@blowdart #12125
Cherry picked from 2.1 (#13746) and updated with new enum values for Unspecified.