Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hosting.Internal APIs #11505

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Remove Hosting.Internal APIs #11505

merged 2 commits into from
Jun 25, 2019

Conversation

Tratcher
Copy link
Member

#11312 Everything became internal except IStartupConfigureContainerFilter and IStartupConfigureServicesFilter which became public but obsolete. These are only used in testing infrastructure, and only for WebHost.

I did need to clean up a mess where the Internal HostingApplication.Context had leaked into TestHost.

@davidfowl davidfowl merged commit f3f9a1c into master Jun 25, 2019
@ghost ghost deleted the tratcher/inthost branch June 25, 2019 04:55
@johnnyreilly
Copy link

When the IStartupConfigureContainerFilter is actually removed then this will create issues for Autofac users relying on this workaround: https://blog.johnnyreilly.com/2020/10/02/autofac-6-integration-tests-and-generic-hosting/

This is to do with ConfigureTestContainer not working with GenericHost - context here: #14907

@ghost
Copy link

ghost commented May 26, 2021

Hi @johnnyreilly. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-hosting Includes Hosting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants