Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Governance alerts of eventsource for signalr package in npm #41729

Closed
1 task done
RichardSunMS opened this issue May 18, 2022 · 3 comments
Closed
1 task done
Labels
area-signalr Includes: SignalR clients and servers

Comments

@RichardSunMS
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

There always be an eventsoure version 1.1.1 reference in the packages-lock.json and this package will be download to node_modules nested folder of signalr package folder.

Manually install version 2.0.2 to my packages.json dependencies not solving the problem, please help upgrade packages or share the steps to mitigate on our side.

Which is causing the Governance alerting with below error:

Root dependencies for eventsource
@microsoft/signalr 6.0.5
@microsoft/signalr-protocol-msgpack 6.0.5
Recommendation
Upgrade to version eventsource - 2.0.2
If you are using NPM 6 or above, you can run npm audit fix on your local machine to fix vulnerabilities. For more info, please visit https://docs.npmjs.com/cli/audit

And here is the quick view of the packages-lock.json file generated:
"node_modules/@microsoft/signalr/node_modules/eventsource": {
"version": "1.1.1",
"resolved": "https://registry.npmjs.org/eventsource/-/eventsource-1.1.1.tgz",
"integrity": "sha512-qV5ZC0h7jYIAOhArFJgSfdyz6rALJyb270714o7ZtNnw2WSJ+eexhKtE0O8LYPRsHZHf2osHKZBxGPvm3kPkCA==",
"dependencies": {
"original": "^1.0.0"
},
"engines": {
"node": ">=0.12.0"
}
},

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@javiercn javiercn added the area-signalr Includes: SignalR clients and servers label May 18, 2022
@BrennanConroy
Copy link
Member

1.1.1 is not vulnerable, the vulnerability database just hasn't been updated. EventSource/eventsource#273 (comment)

@wtgodbe
Copy link
Member

wtgodbe commented May 18, 2022

@RichardSunMS where are you actually seeing this error? We may be able to help find a workaround for you in the meantime

@HorizonXP
Copy link

We are also seeing this vulnerability being picked up by Snyk.

Screen Shot 2022-05-18 at 3 48 58 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

No branches or pull requests

5 participants