Don't exclude System.IO.Pipelines from TargetingPack version check (#…

…39302) Co-authored-by: Will Godbe <wigodbe@microsoft.com>
dotnet · Jan 10, 2022 · d9521ac · d9521ac
1 parent 9fb2d4f
commit d9521ac
Showing 1 changed file with 9 additions and 14 deletions.
diff --git a/src/Framework/test/TargetingPackTests.cs b/src/Framework/test/TargetingPackTests.cs
@@ -109,22 +109,17 @@ public void RefAssemblyReferencesHaveExpectedAssemblyVersions()
 
             Assert.All(dlls, path =>
             {
-                // Skip netstandard2.0 System.IO.Pipelines assembly. References have old versions.
-                var filename = Path.GetFileName(path);
-                if (!string.Equals("System.IO.Pipelines.dll", filename, StringComparison.OrdinalIgnoreCase))
-                {
-                    using var fileStream = File.OpenRead(path);
-                    using var peReader = new PEReader(fileStream, PEStreamOptions.Default);
-                    var reader = peReader.GetMetadataReader(MetadataReaderOptions.Default);
+            using var fileStream = File.OpenRead(path);
+            using var peReader = new PEReader(fileStream, PEStreamOptions.Default);
+            var reader = peReader.GetMetadataReader(MetadataReaderOptions.Default);
 
-                    Assert.All(reader.AssemblyReferences, handle =>
-                    {
-                        var reference = reader.GetAssemblyReference(handle);
-                        var result = 0 == reference.Version.Revision;
+            Assert.All(reader.AssemblyReferences, handle =>
+            {
+                var reference = reader.GetAssemblyReference(handle);
+                var result = (0 == reference.Version.Revision && 0 == reference.Version.Build);
 
-                        Assert.True(result, $"In {filename}, {reference.GetAssemblyName()} has unexpected version {reference.Version}.");
-                    });
-                }
+                Assert.True(result, $"In {Path.GetFileName(path)}, {reference.GetAssemblyName()} has unexpected version {reference.Version}.");
+            });
             });
         }