Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to net6.0 to prevent dependency issues after upgrading MSBuild.Locator #42

Merged
merged 3 commits into from Mar 4, 2021

Conversation

carlossanlop
Copy link
Member

Related to #40
cc @safern @ericstj

@carlossanlop carlossanlop linked an issue Mar 4, 2021 that may be closed by this pull request
@carlossanlop
Copy link
Member Author

carlossanlop commented Mar 4, 2021

The CI fails with: The current .NET SDK does not support targeting .NET 6.0.. Do you know if .NET 6.0 can be used officially in GitHub CI?
Let's find out with a new commit.

@ericstj
Copy link
Member

ericstj commented Mar 4, 2021

Did you make a change to your global.json to pre-requisite this version? Does your repo use Arcade? That should acquire a CLI for building based on global.json contents.

@safern
Copy link
Member

safern commented Mar 4, 2021

Does your repo use Arcade? That should acquire a CLI for building based on global.json contents.

No it doesn't use arcade, but we should add a global.json file with a rollForward policy.

@carlossanlop
Copy link
Member Author

The CI error is weird. I assume it's saying it didn't recognize 6.0.x as a .NET version?

@safern
Copy link
Member

safern commented Mar 4, 2021

I can't push to this branch. The CI error is because when the latest version available in the releases-json index is a preview version, their semver check is failing. So you either need to specify an exact version i.e the full preview version of the SDK or since we need to add a global.json file anyway, don't include a version and that will fallback to the global.json specified version.

Here is a PR to fix that issue in their action by taking an include prerelease parameter: actions/setup-dotnet#110

I put up a PR because I can't push to your branch which adds global.json and the build is green. #46

@safern safern merged commit 9ae7653 into master Mar 4, 2021
@safern safern deleted the net60 branch March 4, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some users report the csproj files are not getting loaded
3 participants