Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log help message for PortToTripleSlash #161

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

carlossanlop
Copy link
Member

When I moved the Log.cs file to a common folder, I did not preserve the two different log messages. I'm bringing the deleted one back here, but putting it in each Configuration class instead, since that's the only place where they are used.

@carlossanlop carlossanlop added port-to-docs Issues related to the PortToDocs tool. port-to-tripleslash labels Apr 18, 2023
@carlossanlop carlossanlop self-assigned this Apr 18, 2023
@carlossanlop
Copy link
Member Author

FYI the CI does not work because .NET 8 cannot be used by GitHub. I'd like to eventually use the dotnet install script like we do in runtime.

I verified this works locally.

@carlossanlop carlossanlop merged commit 2070c3d into dotnet:main Apr 18, 2023
1 of 2 checks passed
@carlossanlop carlossanlop deleted the FixLogHelp branch April 18, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-docs Issues related to the PortToDocs tool. port-to-tripleslash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants