Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Fix Assembly signing issue due to InternalsVisibleTo attribute #773

Merged
merged 2 commits into from Oct 23, 2020

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Oct 23, 2020

We need to remove assembly attribute added in #692 , as the FunctionalTests assembly is not signed, neither it will be signed during build process. The test has been updated to use reflection instead.

@cheenamalhotra cheenamalhotra added this to the 2.1.0-preview2 milestone Oct 23, 2020
@cheenamalhotra cheenamalhotra added this to In progress in SqlClient v2.1 via automation Oct 23, 2020
@cheenamalhotra cheenamalhotra added ✔️ Tests Identifier for test related changes and removed ✔️ Tests Identifier for test related changes labels Oct 23, 2020
SqlClient v2.1 automation moved this from In progress to Reviewer approved Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants