Upgrade MSAL library version #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed tests that compared error messages not owned by SqlClient.
cheenamalhotra
requested review from
David-Engel,
johnnypham and
DavoudEshtehari
David-Engel
approved these changes
Oct 21, 2020
DavoudEshtehari
approved these changes
Oct 21, 2020
As mentioned above, these error messages are "not owned by SqlClient", so they are subject to change from MSAL. It's reasonable to validate that an exception occurred but comparing error message texts to be of match didn't seem a very good idea for our library tests. |
johnnypham
approved these changes
Oct 21, 2020
karinazhou
approved these changes
Oct 22, 2020
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed Asserts that compared error messages not owned by SqlClient.