Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Fix DateTimeOffset size in TdsValueSetter.cs class file. #2453

Merged

Conversation

arellegue
Copy link
Contributor

This PR fixes issue #2423.

@DavoudEshtehari DavoudEshtehari added this to the 6.0-preview1 milestone Apr 11, 2024
@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Something isn't right ! label Apr 11, 2024
@DavoudEshtehari DavoudEshtehari linked an issue Apr 12, 2024 that may be closed by this pull request
@DavoudEshtehari
Copy link
Member

@saitama951 This change would be in contrast with PR #2170. Could you verify this change on your end, as we don't have big endian systems to test, please?

@saitama951
Copy link
Contributor

@DavoudEshtehari I ran the tests. All the test cases passed.

Passed!  - Failed:     0, Passed:   630, Skipped:   151, Total:   781, Duration: 16 m 8 s - ManualTests.dll (net8.0)

@JRahnama
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 83.25792% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 72.72%. Comparing base (9056f13) to head (b074ae9).
Report is 30 commits behind head on main.

❗ Current head b074ae9 differs from pull request most recent head 0f8914f. Consider uploading reports for the commit 0f8914f to get more accurate results

Files Patch % Lines
...qlClient/src/Microsoft/Data/SqlClient/TdsParser.cs 81.37% 19 Missing ⚠️
...crosoft/Data/SqlClient/SSPI/SSPIContextProvider.cs 64.70% 6 Missing ⚠️
...t/Data/SqlClient/SSPI/NativeSSPIContextProvider.cs 85.71% 3 Missing ⚠️
...icrosoft/Data/SqlClient/Server/MetadataUtilsSmi.cs 85.71% 3 Missing ⚠️
...icrosoft/Data/SqlClient/SqlSequentialTextReader.cs 81.25% 3 Missing ⚠️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 85.71% 1 Missing ⚠️
...osoft/Data/SqlClient/TdsParserStateObjectNative.cs 66.66% 1 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2453      +/-   ##
==========================================
+ Coverage   66.85%   72.72%   +5.86%     
==========================================
  Files         304      313       +9     
  Lines       61576    61738     +162     
==========================================
+ Hits        41168    44897    +3729     
+ Misses      20408    16841    -3567     
Flag Coverage Δ
addons 92.88% <ø> (∅)
netcore 77.02% <89.69%> (+5.95%) ⬆️
netfx 70.40% <81.21%> (+5.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@David-Engel David-Engel merged commit 226bdb8 into dotnet:main May 2, 2024
147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.2.0 broke DATETIMEOFFSET(1..4) in TVPs
5 participants