Use memory/span for SSPI generation #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
stuka120
reviewed
Apr 5, 2024
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 8, 2024
|
@David-Engel step 2 in the sspi journey |
|
@David-Engel any chance to get a review here? |
David-Engel
approved these changes
May 6, 2024
|
Pipeline failures are due to test config changes that can be pulled in from main. I ran the Kerberos test pipeline against the branch and all tests passed. This just needs one more reviewer. |
DavoudEshtehari
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes more use of memory/span APIs so that SSPI generation does not need to track arrays and indices.
Part of #2253
Fixes #2441